Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra scraped examples height was changed without noticed #130562

Closed
GuillaumeGomez opened this issue Sep 19, 2024 · 0 comments · Fixed by #130619
Closed

extra scraped examples height was changed without noticed #130562

GuillaumeGomez opened this issue Sep 19, 2024 · 0 comments · Fixed by #130619
Assignees
@GuillaumeGomez
Labels
A-rustdoc-scrape-examples Area: The (unstable) rustdoc scrape-examples feature described in RFC 3123 A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Comments

@GuillaumeGomez
Copy link
Member

In #130069, we realized that the height of extra scraped examples was increased without notice.

Correct version: https://docs.rs/bevy/0.14.1/bevy/app/struct.App.html#method.update
Current version: https://docs.rs/bevy/0.14.2/bevy/app/struct.App.html#method.update
@GuillaumeGomez GuillaumeGomez added A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 19, 2024
@GuillaumeGomez GuillaumeGomez self-assigned this Sep 19, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 19, 2024
@GuillaumeGomez GuillaumeGomez removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 19, 2024
@fmease fmease added the A-rustdoc-scrape-examples Area: The (unstable) rustdoc scrape-examples feature described in RFC 3123 label Sep 19, 2024
@GuillaumeGomez GuillaumeGomez mentioned this issue Sep 20, 2024
Merged
@GuillaumeGomez GuillaumeGomez changed the title extra scraped examples height was increased without noticed extra scraped examples height was changed without noticed Sep 20, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Sep 20, 2024
@GuillaumeGomez
Rollup merge of rust-lang#130619 - GuillaumeGomez:scraped-examples-he…
5708062 
…ight, r=notriddle

Fix scraped examples height

Fixes [rust-lang#130562](rust-lang#130562).

You can test it [here](https://rustdoc.crud.net/imperio/scraped-examples-height/doc/scrape_examples/fn.test_many.html).

I also used this opportunity to reduce the padding on line numbers:

| before | after |
| - | - |
| ![Screenshot from 2024-09-20 16-20-40](https://github.com/user-attachments/assets/9434704c-afe0-4ec3-a1dc-6f3c16d03b3b) | ![Screenshot from 2024-09-20 16-20-13](https://github.com/user-attachments/assets/f3bd01bf-760a-4acd-ba34-8e7db083245a) |

r? `@notriddle`
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 20, 2024
@rust-timer
Unrolled build for rust-lang#130619
fe12aa1 
Rollup merge of rust-lang#130619 - GuillaumeGomez:scraped-examples-height, r=notriddle

Fix scraped examples height

Fixes [rust-lang#130562](rust-lang#130562).

You can test it [here](https://rustdoc.crud.net/imperio/scraped-examples-height/doc/scrape_examples/fn.test_many.html).

I also used this opportunity to reduce the padding on line numbers:

| before | after |
| - | - |
| ![Screenshot from 2024-09-20 16-20-40](https://github.com/user-attachments/assets/9434704c-afe0-4ec3-a1dc-6f3c16d03b3b) | ![Screenshot from 2024-09-20 16-20-13](https://github.com/user-attachments/assets/f3bd01bf-760a-4acd-ba34-8e7db083245a) |

r? `@notriddle`
RalfJung pushed a commit to RalfJung/miri that referenced this issue Sep 21, 2024
@GuillaumeGomez
Rollup merge of #130619 - GuillaumeGomez:scraped-examples-height, r=n…
d3ca348 
…otriddle

Fix scraped examples height

Fixes [#130562](rust-lang/rust#130562).

You can test it [here](https://rustdoc.crud.net/imperio/scraped-examples-height/doc/scrape_examples/fn.test_many.html).

I also used this opportunity to reduce the padding on line numbers:

| before | after |
| - | - |
| ![Screenshot from 2024-09-20 16-20-40](https://github.com/user-attachments/assets/9434704c-afe0-4ec3-a1dc-6f3c16d03b3b) | ![Screenshot from 2024-09-20 16-20-13](https://github.com/user-attachments/assets/f3bd01bf-760a-4acd-ba34-8e7db083245a) |

r? `@notriddle`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-scrape-examples Area: The (unstable) rustdoc scrape-examples feature described in RFC 3123 A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix scraped examples height GuillaumeGomez/rust
3 participants
@GuillaumeGomez @fmease @rustbot