Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: multiple applicable items in scope #130574

Closed
BoxyUwU opened this issue Sep 19, 2024 · 4 comments
Closed

regression: multiple applicable items in scope #130574

BoxyUwU opened this issue Sep 19, 2024 · 4 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@BoxyUwU
Copy link
Member

BoxyUwU commented Sep 19, 2024

[INFO] [stdout] error[E0034]: multiple applicable items in scope
[INFO] [stdout]    --> src/polyfill.rs:300:25
[INFO] [stdout]     |
[INFO] [stdout] 300 |             self.iter().is_sorted_by(|a, b| compare(*a, *b))
[INFO] [stdout]     |                         ^^^^^^^^^^^^ multiple `is_sorted_by` found
[INFO] [stdout]     |
[INFO] [stdout] note: candidate #1 is defined in the trait `SliceIsSorted`
[INFO] [stdout]    --> src/polyfill.rs:271:9

note: if the relevant team already accepted this breakage then the issue can be closed

@BoxyUwU BoxyUwU added I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 19, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 19, 2024
@fmease
Copy link
Member

fmease commented Sep 19, 2024

Very likely #128279: Stabilization of Iterator::is_sorted_by which affects method resolution.

@BoxyUwU BoxyUwU added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 19, 2024
@compiler-errors
Copy link
Member

I wish we had supertrait item shadowing :(

@BoxyUwU BoxyUwU removed the I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ label Sep 19, 2024
@fmease fmease added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Sep 19, 2024
@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 19, 2024
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Sep 24, 2024
@m-ou-se
Copy link
Member

m-ou-se commented Sep 25, 2024

@eggyal Heads-up: your crate will be affected by the stablization of is_sorted_by.

@m-ou-se
Copy link
Member

m-ou-se commented Sep 25, 2024

Discussed in libs meeting; we consider this acceptable.

@m-ou-se m-ou-se closed this as completed Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

7 participants