Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document when and how to .git-blame-ignore-revs #130737

Closed
jieyouxu opened this issue Sep 23, 2024 · 0 comments · Fixed by rust-lang/rustc-dev-guide#2072
Closed

Document when and how to .git-blame-ignore-revs #130737

jieyouxu opened this issue Sep 23, 2024 · 0 comments · Fixed by rust-lang/rustc-dev-guide#2072
Assignees
@jieyouxu
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Sep 23, 2024 •
edited
Loading

I should add some docs in the dev-guide about when and how to add entries to .git-blame-ignore-revs

Originally posted by @jieyouxu in #130736 (comment)

Some large reformatting or refactoring PRs that don't otherwise contain functional changes might be good candidates for .git-blame-ignore-rev (but want to be conservative about which commits qualify so we don't miss out on commits that would benefit from being present in blame)
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 23, 2024
@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 23, 2024
@jieyouxu jieyouxu self-assigned this Sep 23, 2024
@jieyouxu jieyouxu mentioned this issue Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Describe .git-blame-ignore-rev jieyouxu/rustc-dev-guide
2 participants
@jieyouxu @rustbot