Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/debuginfo/macro-stepping.rs remains broken with SingleUseConsts #130896

Open
khuey opened this issue Sep 26, 2024 · 0 comments
Open

tests/debuginfo/macro-stepping.rs remains broken with SingleUseConsts #130896

khuey opened this issue Sep 26, 2024 · 0 comments
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-debugging Working group: Bad Rust debugging experiences WG-llvm Working group: LLVM backend code generation

Comments

@khuey
Copy link
Contributor

khuey commented Sep 26, 2024

This is the part of @saethlin's #128945 that survived #130329. Reordering the IR in the front end in the SingleUseConsts pass breaks the stepping order. This could be mitigated to some extent (but not completely, unclear if it would be sufficient for this test to pass) with better support in LLVM for front ends to express which IR instructions should be considered for breakpoints.

@rustbot label +A-debuginfo +A-testsuite +A-llvm +A-mir +C-bug +T-compiler +WG-debugging +WG-llvm
@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-debugging Working group: Bad Rust debugging experiences WG-llvm Working group: LLVM backend code generation labels Sep 26, 2024
@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-debugging Working group: Bad Rust debugging experiences WG-llvm Working group: LLVM backend code generation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@khuey @saethlin @rustbot