Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for release notes of #130897: library: Compute RUST_EXCEPTION_CLASS from native-endian bytes #131431

Open
3 tasks
rustbot opened this issue Oct 9, 2024 · 3 comments
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Milestone

Comments

@rustbot
Copy link
Collaborator

rustbot commented Oct 9, 2024

This issue tracks the release notes text for #130897.

Steps

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
  • Issue is nominated for release team review of clarity for wider audience.
  • Release team includes text in release notes/blog posts.

Release notes text

The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).

# Compatibility notes
- [The ABI-level exception class of a Rust panic is now encoded with native-endian bytes,
  so it is legible in hex dumps.](https://github.com/rust-lang/rust/pull/130897)

Tip

Use the previous releases categories to help choose which one(s) to use.
The category will be de-duplicated with all the other ones by the release team.

More than one section can be included if needed.

Release blog section

If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
Otherwise leave it empty.

cc @workingjubilee, @thomcc -- origin issue/PR authors and assignees for starting to draft text

@rustbot rustbot added relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 9, 2024
@rustbot rustbot added this to the 1.83.0 milestone Oct 9, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 9, 2024
@workingjubilee
Copy link
Member

workingjubilee commented Oct 9, 2024

Compatibility notes.

I'd probably go with the issue name, ish:

  • The ABI-level exception class of a Rust panic is now encoded with native-endian bytes, so it is legible in hex dumps.

Added the relnotes tag on request of @nbdd0121 whomst maintains some code that works with Rust's exception class, as it does an unwinding implementation. However I should note this is an unstable implementation detail of std, so it's not clear to me whether this should indeed be included in relnotes.

@RalfJung
Copy link
Member

RalfJung commented Oct 9, 2024

Rust panics now are encoded

That sounds like something completely different than what the PR does, IMO. It's no about encoding Rust panics as a whole, it's just about which 64bit-identifier we use to mark an unwind as originating from Rust. The term "exception class" should show up, IMO.

But yeah this is not for the blog post I'd say, just for the "compatibility notes" section.

@workingjubilee
Copy link
Member

Thank you for catching that! I meant to say something about "exception class" but apparently my intent never reached the keyboard. Fixed.

@saethlin saethlin removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants