Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure relies on 'which' to determine what's installed but 'which' isn't always installed #13147

Closed
brson opened this issue Mar 26, 2014 · 0 comments
Closed

configure relies on 'which' to determine what's installed but 'which' isn't always installed #13147

brson opened this issue Mar 26, 2014 · 0 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Mar 26, 2014

The configure script first validates that all the commands it needs exist. It does this with the which command, which itself doesn't always exist (tested on a stock EC2 fedora 20 image). Per @thestinger, sh has the command -v builtin that is equivalent for this purpose.
@pongad pongad mentioned this issue Mar 29, 2014
Closed
@bors bors closed this as completed in 363198b Mar 29, 2014
kchmck added a commit to CREATEspace/VowelCat that referenced this issue May 14, 2014
@kchmck
Use command -v rather than which
f75393c 
Brought to my attention by
rust-lang/rust#13147
notriddle pushed a commit to notriddle/rust that referenced this issue Sep 20, 2022
@bors
Auto merge of rust-lang#13147 - lowr:fix/dyn-ty-inherent-methods, r=V…
7a704f2 
…eykril

fix: handle trait methods as inherent methods for trait-related types

Fixes rust-lang#10677

When resolving methods for trait object types and placeholder types that are bounded by traits, we need to count the methods of the trait and its super traits as inherent methods. This matters because these trait methods have higher priority than the other traits' methods.

Relevant code in rustc: [`assemble_inherent_candidates_from_object()`](https://github.com/rust-lang/rust/blob/0631ea5d73f4a3199c776687b12c20c50a91f0d2/compiler/rustc_typeck/src/check/method/probe.rs#L783-L792) for trait object types, [`assemble_inherent_candidates_from_param()`](https://github.com/rust-lang/rust/blob/0631ea5d73f4a3199c776687b12c20c50a91f0d2/compiler/rustc_typeck/src/check/method/probe.rs#L838-L847) for placeholder types. Notice the second arg of `push_candidate()` is `is_inherent`.
notriddle pushed a commit to notriddle/rust that referenced this issue Sep 20, 2022
@lnicola
Try to fix crash introduced in rust-lang#13147
e54f61d
notriddle pushed a commit to notriddle/rust that referenced this issue Sep 20, 2022
@bors
Auto merge of rust-lang#13257 - rust-lang:revert-13147-fix/dyn-ty-inh…
187bee0 
…erent-methods, r=lnicola

fix: Fix a crash introduced in rust-lang#13147

Reverts rust-lang/rust-analyzer#13147

https://github.com/rust-lang/rust-analyzer/actions/runs/3041499441/jobs/4898678721#step:18:62
flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 8, 2024
@bors
Auto merge of rust-lang#13208 - alex-semenyuk:fix_doc_from_iter_inste…
eb7b676 
…ad_of_collect, r=llogiq

Add clarification for from_iter_instead_of_collect

Close rust-lang#13147

As mentioned at rust-lang#13147 we should prefer to use collect depends on situation so clarify this at documentation and provide examples this cases.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configure uses command -v instead of which
1 participant
@brson