Bootstrap: cargo-miri is called "cargomiri" for check builds

[RalfJung]

When I do ./x.py check, it says:

Checking stage0 cargomiri artifacts (x86_64-unknown-linux-gnu)

Strangely, when I do ./x.py test miri, it uses the correct name:

Building tool cargo-miri (stage0 -> stage1, x86_64-unknown-linux-gnu)

No idea how it is even possible for this tool to have two different names inside bootstrap...

[jieyouxu]

I think this is just because cargo-miri's tool check step is generated through a macro

rust/src/bootstrap/src/core/build_steps/check.rs

Line 478 in fb20e4d

tool_check_step!(CargoMiri, "src/tools/miri/cargo-miri", SourceType::InTree);

this macro generates the check message via

rust/src/bootstrap/src/core/build_steps/check.rs

Line 444 in fb20e4d

let _guard = builder.msg_check(&concat!(stringify!($name), " artifacts").to_lowercase(), target);

there's a to_lowercase in there too. The build step has a different name because that macro explicitly asks for a display name

rust/src/bootstrap/src/core/build_steps/tool.rs

Line 1094 in fb20e4d

CargoMiri, "src/tools/miri/cargo-miri", "cargo-miri", stable=false, add_bins_to_sysroot = ["cargo-miri"];

[jieyouxu]

If I make the macro use a display name,

Checking stage0 cargo-miri artifacts (x86_64-pc-windows-msvc)

[RalfJung]

Ah, I didn't realize those two steps were defined entirely independently.

[jieyouxu]

Anyway, #131597 should make this more consistent.