Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configure script doesn't check for make ahead of time #13179

Closed
pnkfelix opened this issue Mar 28, 2014 · 1 comment · Fixed by #21541
Closed

configure script doesn't check for make ahead of time #13179

pnkfelix opened this issue Mar 28, 2014 · 1 comment · Fixed by #21541

Comments

@pnkfelix
Copy link
Member

This is admittedly silly.

But I was setting up a new machine, and running the rust configure on it, it checks for most of the program it needs at the outset, but for GNU make, it just assumes that it is already there and blithely goes ahead and attempts to configure e.g. LLVM.

Its not hard for an end user to respond to, but it would be slightly cleaner if we checked for make at the same time in configure where we check for everything else.
@pnkfelix
Copy link
Member Author

pnkfelix commented May 7, 2014

part of #8058

steveklabnik added a commit to steveklabnik/rust that referenced this issue Jan 23, 2015
@steveklabnik
Check for make in configure
7aa3ed1 
Fixes rust-lang#13179
@steveklabnik steveklabnik mentioned this issue Jan 23, 2015
Merged
flaper87 added a commit to flaper87/rust that referenced this issue Jan 23, 2015
@flaper87
Rollup merge of rust-lang#21541 - steveklabnik:gh13179, r=huonw
e8f9104 
Fixes rust-lang#13179
flaper87 added a commit to flaper87/rust that referenced this issue Jan 24, 2015
@flaper87
Rollup merge of rust-lang#21541 - steveklabnik:gh13179, r=huonw
8a2eee6 
Fixes rust-lang#13179
flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 8, 2024
@bors
Auto merge of rust-lang#13179 - GuillaumeGomez:clean-up-lints-page-js…
5342092 
…, r=Alexendoo

Clean up clippy lints page JS source code

Just a small cleanup for the lints page JS source code.

r? `@Alexendoo`

changelog: Clean up clippy lints page JS source code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check for make in configure steveklabnik/rust
1 participant
@pnkfelix