Skip to content

unable to perform type-based search on foreign functions #131804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lolbinarycat opened this issue Oct 16, 2024 · 1 comment · Fixed by #132123
Closed

unable to perform type-based search on foreign functions #131804

lolbinarycat opened this issue Oct 16, 2024 · 1 comment · Fixed by #132123
Assignees
@lolbinarycat
Labels
A-rustdoc-search Area: Rustdoc's search feature A-type-based-search Area: Searching rustdoc pages using type signatures C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@lolbinarycat
Copy link
Contributor

for example searching for functions that return FILE in libc yields no result instead of matching fopen.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 16, 2024
@lolbinarycat lolbinarycat self-assigned this Oct 16, 2024
@lolbinarycat lolbinarycat added A-type-based-search Area: Searching rustdoc pages using type signatures A-rustdoc-search Area: Rustdoc's search feature labels Oct 16, 2024
@lolbinarycat
Copy link
Contributor Author

the issue is that get_function_type_for_search doesn't match ForeignFunctionItem

@fmease fmease added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 16, 2024
lolbinarycat added a commit to lolbinarycat/rust that referenced this issue Oct 25, 2024
@lolbinarycat
allow type-based search on foreign functions
89bbecd 
fixes rust-lang#131804
@lolbinarycat lolbinarycat mentioned this issue Oct 25, 2024
Merged
lolbinarycat added a commit to lolbinarycat/rust that referenced this issue Oct 25, 2024
@lolbinarycat
allow type-based search on foreign functions
20b0345 
fixes rust-lang#131804
lolbinarycat added a commit to lolbinarycat/rust that referenced this issue Oct 25, 2024
@lolbinarycat
allow type-based search on foreign functions
d62cbaa 
fixes rust-lang#131804
lolbinarycat added a commit to lolbinarycat/rust that referenced this issue Oct 25, 2024
@lolbinarycat
allow type-based search on foreign functions
e0ed6be 
fixes rust-lang#131804
lolbinarycat added a commit to lolbinarycat/rust that referenced this issue Oct 25, 2024
@lolbinarycat
allow type-based search on foreign functions
6c7720c 
fixes rust-lang#131804
lolbinarycat added a commit to lolbinarycat/rust that referenced this issue Oct 25, 2024
@lolbinarycat
allow type-based search on foreign functions
acc8555 
fixes rust-lang#131804
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Oct 27, 2024
@workingjubilee
Rollup merge of rust-lang#132123 - lolbinarycat:rustdoc-search-foreig…
dfe8938 
…n-func, r=notriddle

allow type-based search on foreign functions

fixes rust-lang#131804

preferably will be merged after rust-lang#129708, but that may take a while to be approved due to being a new feature, whereas this is definitely a bug, and should be fixed.
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Oct 27, 2024
@workingjubilee
Rollup merge of rust-lang#132123 - lolbinarycat:rustdoc-search-foreig…
05f784c 
…n-func, r=notriddle

allow type-based search on foreign functions

fixes rust-lang#131804

preferably will be merged after rust-lang#129708, but that may take a while to be approved due to being a new feature, whereas this is definitely a bug, and should be fixed.
@bors bors closed this as completed in 09773b4 Oct 27, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 27, 2024
@rust-timer
Unrolled build for rust-lang#132123
d65f9c5 
Rollup merge of rust-lang#132123 - lolbinarycat:rustdoc-search-foreign-func, r=notriddle

allow type-based search on foreign functions

fixes rust-lang#131804

preferably will be merged after rust-lang#129708, but that may take a while to be approved due to being a new feature, whereas this is definitely a bug, and should be fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lolbinarycat lolbinarycat

Labels
A-rustdoc-search Area: Rustdoc's search feature A-type-based-search Area: Searching rustdoc pages using type signatures C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow type-based search on foreign functions lolbinarycat/rust
3 participants
@fmease @lolbinarycat @rustbot