Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DESTDIR currently broken #13192

Closed
brson opened this issue Mar 29, 2014 · 1 comment
Closed

DESTDIR currently broken #13192

brson opened this issue Mar 29, 2014 · 1 comment
Assignees
@brson

Comments

@brson
Copy link
Contributor

brson commented Mar 29, 2014

Running make install with DESTDIR no longer works.
@brson brson added the A-build label Mar 29, 2014
@brson brson self-assigned this Mar 29, 2014
@brson
Copy link
Contributor Author

brson commented Mar 29, 2014

Fixed by #13187

@thestinger thestinger mentioned this issue Mar 29, 2014
Closed
@brson brson closed this as completed Mar 30, 2014
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Sep 13, 2022
@bors
Auto merge of rust-lang#13192 - lowr:fix/dyn-sort-all-bounds, r=Veykril
6dfd8ae 
fix: sort all bounds on trait object types

Fixes rust-lang#13181

rust-lang#12793 allowed different ordering of trait bounds in trait object types but failed to account for the ordering of projection bounds. I opted for sorting all the bounds at once rather than splitting them into `SmallVec`s so it's easier to do the same thing for other bounds when we have them.
bors added a commit to rust-lang-ci/rust that referenced this issue Oct 18, 2022
@bors
Auto merge of rust-lang#13382 - lowr:fix/reorder-dyn-bounds-on-render…
d08f1c3 
…, r=lowr

fix: reorder dyn bounds on render

Fixes rust-lang#13368

rust-lang#13192 changed the order of dyn bounds, violating the [contract](https://github.com/rust-lang/rust-analyzer/blob/3a69435af7a1e6273744085cb251adb2b9c30a03/crates/hir-ty/src/display.rs#L896-L901) with `write_bounds_like_dyn_trait()` on render. The projection bounds are expected to come right after the trait bound they are accompanied with.

Although the reordering procedure can be made a bit more efficient, I opted for relying only on the [invariants](https://github.com/rust-lang/rust-analyzer/blob/3a69435af7a1e6273744085cb251adb2b9c30a03/crates/hir-ty/src/lower.rs#L995-L998) currently documented in `lower_dyn_trait()`. It's not the hottest path and dyn bounds tend to be short so I believe it shouldn't hurt performance noticeably.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brson