-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compiletest: allow only running a test if we have a *specific* llvm major version #132348
Comments
Mentoring instructions:
|
@rustbot claim |
@rustbot claim |
Unfortunately, we can't use |
That's fine. |
Rollup merge of rust-lang#132995 - Eclips4:issue-132348, r=jieyouxu compiletest: Add ``exact-llvm-major-version`` directive Now contributors don't need to use `min-llvm-version: X` + `ignore-llvm-version: X+1 - 99`, so they can simply use `exact-llvm-major-version: X` To be honest, I didn't find any usages of that hack other than the one mentioned in the issue. ( `tests/codegen/try_question_mark_nop.rs`) Closes rust-lang#132348. rustc-dev-guide PR for `//@ exact-llvm-major-version`: rust-lang/rustc-dev-guide#2135 r? jieyouxu
tests/codegen/try_question_mark_nop.rs
has a hack likewe should allow the test writer to specify a
//@ only-llvm-major-version: 19
which will only run the test if the llvm's major version matches19
. Instead of having to hack this by usingmin-llvm-version
+ignore-llvm-version
.The text was updated successfully, but these errors were encountered: