Skip to content

Tracking issue for release notes of #132402: Remove support for decompressing dylib metadata #132412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
rustbot opened this issue Oct 31, 2024 · 3 comments
Closed
1 of 3 tasks
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@rustbot
Copy link
Collaborator

rustbot commented Oct 31, 2024

This issue tracks the release notes text for #132402.

Steps

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
  • Issue is nominated for release team review of clarity for wider audience.
  • Release team includes text in release notes/blog posts.

Release notes text

The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).

# Compatibility notes
- [Remove support for older dylibs from rust-analyzer proc macros](https://github.com/rust-lang/rust/pull/132402)

Tip

Use the previous releases categories to help choose which one(s) to use.
The category will be de-duplicated with all the other ones by the release team.

More than one section can be included if needed.

Release blog section

If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
Otherwise leave it empty.

cc @bjorn3, @jieyouxu -- origin issue/PR authors and assignees for starting to draft text

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 31, 2024
@jieyouxu jieyouxu removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. A-testsuite Area: The testsuite used to check the correctness of rustc labels Oct 31, 2024
@Noratrieb
Copy link
Member

the only user-affecting change here is the rust-analyzer proc macro server, but i'm unsure whether that's even worth pointing out

@jieyouxu
Copy link
Member

Feel free to close if this is not worth even the compat notes, opened just in case.

@bjorn3
Copy link
Member

bjorn3 commented Oct 31, 2024

Probably not worth it. The only case where this can even show up at all is if you compiled a dylib with a rustc version that is well over a year old and accidentally try to load it with a rustc version from after this PR, in which case you get a slightly worse diagnostic.

@bjorn3 bjorn3 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2024
@rustbot rustbot added this to the 1.84.0 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants