Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have bots automatically sign distributable artifacts #13252

Closed
brson opened this issue Apr 1, 2014 · 5 comments
Closed

Have bots automatically sign distributable artifacts #13252

brson opened this issue Apr 1, 2014 · 5 comments

Comments

@brson
Copy link
Contributor

brson commented Apr 1, 2014

We sign releases manually right now, and don't sign nightlies. Would be better if the automation just did this for us.
@brson brson mentioned this issue Apr 1, 2014
Closed
@thestinger thestinger mentioned this issue Apr 1, 2014
Closed
@bheesham
Copy link
Contributor

bheesham commented Dec 3, 2014

Hey @brson , is there anything I can do here?

@brson brson mentioned this issue Dec 3, 2014
Closed
65 tasks
@brson
Copy link
Contributor Author

brson commented Dec 3, 2014

@bheesham Thanks for the offer but I think not. It requires access to the automation infrastructure that I'm not currently prepared to provide.

@brson
Copy link
Contributor Author

brson commented Jan 2, 2015

This is done. Thanks @bheesham!

@brson brson closed this as completed Jan 2, 2015
@l0kod
Copy link
Contributor

l0kod commented Jan 3, 2015

Great, the signatures seems to be there but without link in the download pages.

@l0kod
Copy link
Contributor

l0kod commented Jan 3, 2015

The src/etc/get-snapshot.py should use the signatures as well.

matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Nov 16, 2022
@bors
Auto merge of rust-lang#13602 - lowr:fix/nameres-transitive-visibilit…
57cc2a6 
…y, r=Veykril

fix: check visibility of each path segment

Upon path resolution, we have not been checking if every def pointed to by each segment of the path is visible from the original module. This leads to incorrect import resolutions, in particular when one uses glob imports and names collide.

There is decent amount of changes in this PR because:
- some of our tests were not correct in terms of visibility
  - I left several basic nameres tests as-is (with expect test updated) since I thought it would be nice to ensure we don't resolve defs that are not visible.
- `fix_visibility` assist relied on `Semantics::resolve_path()`, which uses the name resolution procedure I'm fixing and wouldn't be able to "see through" the items with strict visibility with this patch

The first commit is the gist of the fix itself.

Fixes rust-lang#10991
Fixes rust-lang#11473
Fixes rust-lang#13252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brson @bheesham @l0kod