Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The msg "perhaps this crate needs to be recompiled?" should include paths #13266

Closed
pnkfelix opened this issue Apr 2, 2014 · 0 comments · Fixed by #13284
Closed

The msg "perhaps this crate needs to be recompiled?" should include paths #13266

pnkfelix opened this issue Apr 2, 2014 · 0 comments · Fixed by #13284

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Apr 2, 2014

This was a very interesting and potentially useful warning from rustc:

cfg/mod.rs:13:1: 13:20 error: found possibly newer version of crate `std` which `rustc` depends on
cfg/mod.rs:13 extern crate rustc;
              ^~~~~~~~~~~~~~~~~~~
cfg/mod.rs:13:1: 13:20 note: perhaps this crate needs to be recompiled?
cfg/mod.rs:13 extern crate rustc;
              ^~~~~~~~~~~~~~~~~~~

It would be even more useful if it told me the paths it was using for the two crates involved (std and rustc), so that I could be sure that the files I am inspecting (in my file system, and in practice in my makefile debugging) actually correspond to the ones that rustc is informing me about.
@pnkfelix pnkfelix mentioned this issue Apr 3, 2014
Merged
pnkfelix added a commit to pnkfelix/rust that referenced this issue Apr 5, 2014
@pnkfelix
Rough regression test for rust-lang#13266.
f4cde4e 
All it checks, unfortunately, is that you actually printed at least
two lines for crateA paths and at least one line for crateB paths.
But that's enough to capture the spirit of the bug, I think.  I did
not bother trying to verify that the paths themselves reflected where
the crates end up.
bors added a commit that referenced this issue Apr 5, 2014
@bors
auto merge of #13284 : pnkfelix/rust/more-fs-info-on-crate-mismatch, …
339d400 
…r=alexcrichton

Fix #13266.

There is a little bit of acrobatics in the definition of `crate_paths`
to avoid calling `clone()` on the dylib/rlib unless we actually are
going to need them.

The other oddity is that I have replaced the `root_ident: Option<&str>`
parameter with a `root: &Option<CratePaths>`, which may surprise one
who was expecting to see something like: `root: Option<&CratePaths>`.
I went with the approach here because I could not come up with code for
the alternative that was acceptable to the borrow checker.
pnkfelix added a commit to pnkfelix/rust that referenced this issue Apr 7, 2014
@pnkfelix
After a hash mismatch error, emit file-system paths of crates involved.
ca6f148 
Fix rust-lang#13266.

There is a little bit of acrobatics in the definition of `crate_paths`
to avoid calling `clone()` on the dylib/rlib unless we actually are
going to need them.

The other oddity is that I have replaced the `root_ident: Option<&str>`
parameter with a `root: &Option<CratePaths>`, which may surprise one
who was expecting to see something like: `root: Option<&CratePaths>`.
I went with the approach here because I could not come up with code for
the alternative that was acceptable to the borrow checker.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

After a hash mismatch error, emit file-system paths of crates involved. pnkfelix/rust
1 participant
@pnkfelix