You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sorairolake opened this issue
Nov 14, 2024
· 2 comments
· Fixed by #133019
Assignees
Labels
A-docsArea: documentation for any part of the project, including the compiler, standard library, and toolsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.
-Unbounded shift left. Computes `self << rhs`, without bounding the value of `rhs`+Unbounded shift left. Computes `self << rhs`, without bounding the value of `rhs`.
-Unbounded shift right. Computes `self >> rhs`, without bounding the value of `rhs`+Unbounded shift right. Computes `self >> rhs`, without bounding the value of `rhs`.
fmease
added
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
and removed
needs-triage
This issue may need triage. Remove it if it has been sufficiently triaged.
labels
Nov 14, 2024
sorairolake
changed the title
Missing period and colon in the description of methods for some primitive integer types
Missing period and colon in the description of methods for some primitive types
Nov 14, 2024
Rollup merge of rust-lang#133019 - sorairolake:add-missing-period-and-colon, r=tgross35
docs: Fix missing period and colon in methods for primitive types
Closesrust-lang#133018
A-docsArea: documentation for any part of the project, including the compiler, standard library, and toolsE-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.
Location
Methods for signed integer types which are missing a period:
i32::unbounded_shl
i32::unbounded_shr
i32::overflowing_sub
i32::overflowing_sub_unsigned
Methods for unsigned integer types which are missing a period:
u32::unbounded_shl
u32::unbounded_shr
u32::overflowing_sub
Methods for primitive types which are missing a colon:
u32::overflowing_add
u32::overflowing_sub
u32::overflowing_div
u32::overflowing_div_euclid
u32::overflowing_rem
u32::overflowing_rem_euclid
u32::overflowing_neg
u32::overflowing_shl
u32::overflowing_shr
str::parse
Summary
I think the methods in the top two chunks above are missing a period at the end of the sentence.
For
i32::unbounded_shl
andu32::unbounded_shl
:For
i32::unbounded_shr
andu32::unbounded_shr
:For
i32::overflowing_sub
andu32::overflowing_sub
:For
i32::overflowing_sub_unsigned
:Also, I think the methods in the last chunk are missing a colon in the examples section.
For
u32::overflowing_add
,u32::overflowing_sub
,u32::overflowing_div
, etc.:The text was updated successfully, but these errors were encountered: