Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust.debug-assertions = true should be incompatible with rust.download-rustc = true | 'if-unchanged' atm #133132

Open
jieyouxu opened this issue Nov 17, 2024 · 0 comments · May be fixed by #133068
Open

rust.debug-assertions = true should be incompatible with rust.download-rustc = true | 'if-unchanged' atm #133132

jieyouxu opened this issue Nov 17, 2024 · 0 comments · May be fixed by #133068
Assignees
@jieyouxu
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jieyouxu
Copy link
Member

Before Enable debug assertions on alt builds #131077 lands, the alt rustc builds do not have rustc debug assertions enabled. However, currently rust.download-rustc = true | "if-unchanged" incorrectly assumes that the alt rustc has rustc debug assertions enabled (it does have llvm debug assertions enabled but not rustc debug assertions). This was the reason why #132789 was failing.

See the investigation and #133131 for details.
@jieyouxu jieyouxu added C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 17, 2024
@jieyouxu jieyouxu self-assigned this Nov 17, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 17, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 17, 2024
This was referenced Nov 17, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
2 participants
@jieyouxu @rustbot