Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some debug-assertion crash tests #132789

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add some debug-assertion crash tests #132789

wants to merge 1 commit into from
+159 −0

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Nov 8, 2024 •
edited by jieyouxu
Loading

r? ghost

try-job: x86_64-gnu

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 8, 2024
@matthiaskrgr
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 8, 2024
@bors
Auto merge of rust-lang#132789 - matthiaskrgr:debug_tests, r=<try>
5b739e4 
add some debug-assertion crash tests

r? ghost

try-job: x86_64-gnu-llvm-18
@bors
Copy link
Contributor

bors commented Nov 8, 2024

⌛ Trying commit b521cae with merge 5b739e4...

@matthiaskrgr
Copy link
Member Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2024
@bors
Copy link
Contributor

bors commented Nov 8, 2024

☀️ Try build successful - checks-actions
Build commit: 5b739e4 (5b739e404d35520d5ee76f6a553037de34fd6ff0)

saethlin
saethlin reviewed Nov 8, 2024
View reviewed changes
tests/crashes/131451.rs Outdated Show resolved Hide resolved
@matthiaskrgr matthiaskrgr marked this pull request as ready for review November 16, 2024 12:35
@matthiaskrgr
Copy link
Member Author

r? @jieyouxu

jieyouxu
jieyouxu reviewed Nov 16, 2024
View reviewed changes
tests/crashes/116979.rs
//@ needs-rustc-debug-assertions

#![feature(dyn_star)]
#![allow(incomplete_features)]
Copy link
Member

@jieyouxu jieyouxu Nov 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question/discussion: should we even add crashes tests for incomplete features...? Cuz like, it's known to be incomplete, right? I feel like we should just backlink the bug report to the tracking issue (and tag it along with the github subissues thing), because otherwise if someone wants to drive dyn_star forward a crashes test might just be friction idk

cc https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Should.20crashes.20test.20include.20incomplete.20features.3F

jieyouxu
jieyouxu approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, I'm inclined to r+ this because crashes tests are easy to remove and helps to detect changes (incl. fixes). Whether to add incomplete_features crashes tests in the future can be discussed separately.

@jieyouxu
Copy link
Member

@bors r+ rollup=iffy

@bors
Copy link
Contributor

bors commented Nov 16, 2024

📌 Commit 3a2c247 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2024
@bors
Auto merge of rust-lang#132789 - matthiaskrgr:debug_tests, r=jieyouxu
964b99f 
add some debug-assertion crash tests

r? ghost

try-job: x86_64-gnu-llvm-18
@bors
Copy link
Contributor

bors commented Nov 16, 2024

⌛ Testing commit 3a2c247 with merge 964b99f...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
test [crashes] tests/crashes/116519-2.rs ... ok
test [crashes] tests/crashes/116554.rs ... ok
test [crashes] tests/crashes/116519.rs ... ok
test [crashes] tests/crashes/116947.rs ... ok
2024-11-16T13:35:21.168460Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/116979.rs ... FAILED
test [crashes] tests/crashes/117392.rs ... ok
test [crashes] tests/crashes/117460.rs ... ok
test [crashes] tests/crashes/117629.rs ... ok
test [crashes] tests/crashes/117629.rs ... ok
test [crashes] tests/crashes/117496.rs ... ok
test [crashes] tests/crashes/117696-2.rs ... ok
test [crashes] tests/crashes/115994.rs ... ok
test [crashes] tests/crashes/117795.rs ... ok
2024-11-16T13:35:21.806523Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/117808.rs ... FAILED
2024-11-16T13:35:21.815537Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/118038.rs ... ok
test [crashes] tests/crashes/118244.rs ... ok
test [crashes] tests/crashes/117696-1.rs ... ok
test [crashes] tests/crashes/118603.rs ... ok
test [crashes] tests/crashes/118603.rs ... ok
2024-11-16T13:35:21.933557Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/118778.rs ... FAILED
2024-11-16T13:35:21.976716Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/118952-2.rs ... ok
test [crashes] tests/crashes/119095.rs ... ok
test [crashes] tests/crashes/118952.rs ... ok
test [crashes] tests/crashes/119694.rs ... ok
---
test [crashes] tests/crashes/119786.rs ... ok
test [crashes] tests/crashes/119824.rs ... ok
test [crashes] tests/crashes/120016.rs ... ok
test [crashes] tests/crashes/120033.rs ... ok
2024-11-16T13:35:22.255685Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/120254.rs ... ok
test [crashes] tests/crashes/120811.rs ... ok
test [crashes] tests/crashes/120873.rs ... ok
test [crashes] tests/crashes/120911.rs ... ok
test [crashes] tests/crashes/120911.rs ... ok
test [crashes] tests/crashes/121097.rs ... ok
2024-11-16T13:35:22.346103Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/121127.rs ... ok
test [crashes] tests/crashes/121363.rs ... ok
test [crashes] tests/crashes/121411.rs ... ok
test [crashes] tests/crashes/121429.rs ... ok
---
test [crashes] tests/crashes/123690.rs ... ok
test [crashes] tests/crashes/123810.rs ... ok
test [crashes] tests/crashes/123809.rs ... ok
test [crashes] tests/crashes/122823.rs ... ok
2024-11-16T13:35:23.181516Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/123887.rs ... ok
test [crashes] tests/crashes/123887.rs ... ok
2024-11-16T13:35:23.201453Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/123893.rs ... ok
test [crashes] tests/crashes/123959.rs ... ok
test [crashes] tests/crashes/124021.rs ... ok
test [crashes] tests/crashes/124020.rs ... ok
---
test [crashes] tests/crashes/129425.rs ... ok
test [crashes] tests/crashes/129444.rs ... ok
test [crashes] tests/crashes/129556.rs ... ok
test [crashes] tests/crashes/130346.rs ... ok
2024-11-16T13:35:24.557177Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/130411.rs ... ok
test [crashes] tests/crashes/108499.rs ... ok
test [crashes] tests/crashes/130425.rs ... ok
test [crashes] tests/crashes/130521.rs ... ok
---
test [crashes] tests/crashes/131758.rs ... ok
test [crashes] tests/crashes/131762.rs ... ok
test [crashes] tests/crashes/131787.rs ... ok
test [crashes] tests/crashes/131886.rs ... ok
2024-11-16T13:35:25.259358Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/132126.rs ... ok
test [crashes] tests/crashes/132320.rs ... ok
test [crashes] tests/crashes/132127.rs ... ok
test [crashes] tests/crashes/132142.rs ... ok
---
failures:

---- [crashes] tests/crashes/116979.rs stdout ----

error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/116979.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- [crashes] tests/crashes/117808.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/117808.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/117877.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/117877.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/118778.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/118778.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/118784.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/118784.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/120175.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/120175.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/121176.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/121176.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/123861.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/123861.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/123862.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/123862.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/130395.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/130395.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/132055.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/132055.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:


failures:
    [crashes] tests/crashes/116979.rs

@bors
Copy link
Contributor

bors commented Nov 16, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 16, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Nov 17, 2024 •
edited
Loading

Hm, that's weird... Is the directive implementation wrong I wonder

EDIT: I'm missing something because this passes locally and is ignored when rustc built without debug assertions as I expected.

cc https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/When.20is.20rustc.20built.20with.20debug.20assertions.3F

@jieyouxu
Copy link
Member

It doesn't even fail locally in x86_64-gnu, I'm missing something

@jieyouxu
Copy link
Member

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2024
@bors
Auto merge of rust-lang#132789 - matthiaskrgr:debug_tests, r=<try>
0bc8c97 
add some debug-assertion crash tests

r? ghost

try-job: x86_64-gnu
@bors
Copy link
Contributor

bors commented Nov 17, 2024

⌛ Trying commit 3a2c247 with merge 0bc8c97...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config remote.upstream.fetch=+refs/heads/*:refs/remotes/upstream/*
file:.git/config submodule.library/backtrace.active=true
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
---
test [crashes] tests/crashes/116519.rs ... ok
test [crashes] tests/crashes/116554.rs ... ok
test [crashes] tests/crashes/116947.rs ... ok
test [crashes] tests/crashes/117392-2.rs ... ok
2024-11-17T10:48:06.028897Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/117392.rs ... ok
test [crashes] tests/crashes/117460.rs ... ok
test [crashes] tests/crashes/117629.rs ... ok
test [crashes] tests/crashes/117496.rs ... ok
test [crashes] tests/crashes/117496.rs ... ok
test [crashes] tests/crashes/117696-2.rs ... ok
test [crashes] tests/crashes/115994.rs ... ok
test [crashes] tests/crashes/117795.rs ... ok
2024-11-17T10:48:06.605992Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/117808.rs ... FAILED
2024-11-17T10:48:06.648897Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/118038.rs ... ok
test [crashes] tests/crashes/118244.rs ... ok
test [crashes] tests/crashes/118603.rs ... ok
test [crashes] tests/crashes/117696-1.rs ... ok
test [crashes] tests/crashes/117696-1.rs ... ok
2024-11-17T10:48:06.805344Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/118778.rs ... FAILED
2024-11-17T10:48:06.843150Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/118952-2.rs ... ok
test [crashes] tests/crashes/118952.rs ... ok
test [crashes] tests/crashes/119095.rs ... ok
test [crashes] tests/crashes/119692.rs ... ok
---
test [crashes] tests/crashes/119701.rs ... ok
test [crashes] tests/crashes/119824.rs ... ok
test [crashes] tests/crashes/119786.rs ... ok
test [crashes] tests/crashes/120016.rs ... ok
2024-11-17T10:48:07.079745Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/120033.rs ... ok
test [crashes] tests/crashes/120254.rs ... ok
test [crashes] tests/crashes/120811.rs ... ok
test [crashes] tests/crashes/120873.rs ... ok
test [crashes] tests/crashes/120873.rs ... ok
test [crashes] tests/crashes/121097.rs ... ok
test [crashes] tests/crashes/120911.rs ... ok
test [crashes] tests/crashes/121127.rs ... ok
2024-11-17T10:48:07.197972Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/121363.rs ... ok
test [crashes] tests/crashes/121411.rs ... ok
test [crashes] tests/crashes/121429.rs ... ok
test [crashes] tests/crashes/121575.rs ... ok
---
test [crashes] tests/crashes/123141.rs ... ok
test [crashes] tests/crashes/123690.rs ... ok
test [crashes] tests/crashes/122823.rs ... ok
test [crashes] tests/crashes/123809.rs ... ok
2024-11-17T10:48:08.015692Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/123810.rs ... ok
test [crashes] tests/crashes/123810.rs ... ok
2024-11-17T10:48:08.045261Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/123893.rs ... ok
test [crashes] tests/crashes/123887.rs ... ok
test [crashes] tests/crashes/123959.rs ... ok
test [crashes] tests/crashes/124021.rs ... ok
---
test [crashes] tests/crashes/129425.rs ... ok
test [crashes] tests/crashes/129444.rs ... ok
test [crashes] tests/crashes/129556.rs ... ok
test [crashes] tests/crashes/130346.rs ... ok
2024-11-17T10:48:09.398252Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/130411.rs ... ok
test [crashes] tests/crashes/130425.rs ... ok
test [crashes] tests/crashes/130104.rs ... ok
test [crashes] tests/crashes/130310.rs ... ok
---
test [crashes] tests/crashes/131787.rs ... ok
test [crashes] tests/crashes/131886.rs ... ok
test [crashes] tests/crashes/131762.rs ... ok
test [crashes] tests/crashes/132126.rs ... ok
2024-11-17T10:48:10.167860Z ERROR compiletest::runtest: fatal error, panic: "crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`."
test [crashes] tests/crashes/132127.rs ... ok
test [crashes] tests/crashes/132142.rs ... ok
test [crashes] tests/crashes/132320.rs ... ok
test [crashes] tests/crashes/132330.rs ... ok
---
failures:

---- [crashes] tests/crashes/116979.rs stdout ----

error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/116979.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- [crashes] tests/crashes/117808.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/117808.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/117877.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/117877.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/118778.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/118778.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/118784.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/118784.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/120175.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/120175.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/121176.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/121176.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/123861.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/123861.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/123862.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/123862.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/130395.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/130395.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:

---- [crashes] tests/crashes/132055.rs stdout ----


error: crashtest no longer crashes/triggers ICE, horray! Please give it a meaningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit. Adding 'Fixes #<issueNr>' to your PR description ensures that the corresponding ticket is auto-closed upon merge. If you want to see verbose output, set `COMPILETEST_VERBOSE_CRASHES=1`.
thread '[crashes] tests/crashes/132055.rs' panicked at src/tools/compiletest/src/runtest/crashes.rs:17:18:


failures:
    [crashes] tests/crashes/116979.rs

@bors
Copy link
Contributor

bors commented Nov 17, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2024
@jieyouxu
Copy link
Member

@rustbot blocked (investigating in #133131)

@rustbot rustbot added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 17, 2024
@jieyouxu jieyouxu mentioned this pull request Nov 17, 2024
Open
@jieyouxu
Copy link
Member

This needs #133068 to land to fix #133132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saethlin saethlin saethlin left review comments

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matthiaskrgr @bors @jieyouxu @rust-log-analyzer @saethlin @rustbot