Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parsing << is incorrect for closure types #13324

Closed
alexcrichton opened this issue Apr 4, 2014 · 4 comments · Fixed by #19780
Closed

Parsing << is incorrect for closure types #13324

alexcrichton opened this issue Apr 4, 2014 · 4 comments · Fixed by #19780
Labels
A-parser Area: The parsing of Rust source code to an AST P-medium Medium priority
Milestone
1.0

Comments

@alexcrichton
Copy link
Member

This is a valid type signature, but it fails to parse today.

Option<<'a>||>

Most closure parsing was fixed in #13268, but this is the remaining bits of #11209.

Nominating because #11209 was nominated. I don't believe this should block 1.0.
@pnkfelix
Copy link
Member

This is a grammar issue, but cmr does point out that its not a backwards compatibility hazard since it just represents programs that fail to parse today (and that we could fix backwards compatibly tomorrow).

We'll keep it on the 1.0 milestone (since we would like to resolve these grammatical issues), but it is just P-high (not a backcompat-lang like #11209 was).

@pnkfelix pnkfelix added this to the 1.0 milestone Apr 10, 2014
@huonw huonw mentioned this issue Apr 17, 2014
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 13, 2014
@alexcrichton
syntax: Fix parsing << with closure types
93edd7e 
This uses the trick of replacing the << token with a < token to parse closure
types correctly.

Closes rust-lang#13324
@ghost ghost mentioned this issue Dec 12, 2014
Merged
brson added a commit to brson/rust that referenced this issue Dec 12, 2014
@brson
rollup merge of rust-lang#19780: jakub-/e-needstest
20cbbff 
Closes rust-lang#5988.
Closes rust-lang#10176.
Closes rust-lang#10456.
Closes rust-lang#12744.
Closes rust-lang#13264.
Closes rust-lang#13324.
Closes rust-lang#14182.
Closes rust-lang#15381.
Closes rust-lang#15444.
Closes rust-lang#15480.
Closes rust-lang#15756.
Closes rust-lang#16822.
Closes rust-lang#16966.
Closes rust-lang#17351.
Closes rust-lang#17503.
Closes rust-lang#17545.
Closes rust-lang#17771.
Closes rust-lang#17816.
Closes rust-lang#17897.
Closes rust-lang#17905.
Closes rust-lang#18188.
Closes rust-lang#18232.
Closes rust-lang#18345.
Closes rust-lang#18389.
Closes rust-lang#18400.
Closes rust-lang#18502.
Closes rust-lang#18611.
Closes rust-lang#18783.
Closes rust-lang#19009.
Closes rust-lang#19081.
Closes rust-lang#19098.
Closes rust-lang#19127.
Closes rust-lang#19135.
brson added a commit to brson/rust that referenced this issue Dec 13, 2014
@brson
rollup merge of rust-lang#19780: jakub-/e-needstest
c59b9b7 
Closes rust-lang#5988.
Closes rust-lang#10176.
Closes rust-lang#10456.
Closes rust-lang#12744.
Closes rust-lang#13264.
Closes rust-lang#13324.
Closes rust-lang#14182.
Closes rust-lang#15381.
Closes rust-lang#15444.
Closes rust-lang#15480.
Closes rust-lang#15756.
Closes rust-lang#16822.
Closes rust-lang#16966.
Closes rust-lang#17351.
Closes rust-lang#17503.
Closes rust-lang#17545.
Closes rust-lang#17771.
Closes rust-lang#17816.
Closes rust-lang#17897.
Closes rust-lang#17905.
Closes rust-lang#18188.
Closes rust-lang#18232.
Closes rust-lang#18345.
Closes rust-lang#18389.
Closes rust-lang#18400.
Closes rust-lang#18502.
Closes rust-lang#18611.
Closes rust-lang#18783.
Closes rust-lang#19009.
Closes rust-lang#19081.
Closes rust-lang#19098.
Closes rust-lang#19127.
Closes rust-lang#19135.
bors added a commit that referenced this issue Dec 18, 2014
@bors
auto merge of #19780 : jakub-/rust/e-needstest, r=alexcrichton
2a23159 
Closes #5988.
Closes #10176.
Closes #10456.
Closes #12744.
Closes #13264.
Closes #13324.
Closes #14182.
Closes #15381.
Closes #15444.
Closes #15480.
Closes #15756.
Closes #16822.
Closes #16966.
Closes #17351.
Closes #17503.
Closes #17545.
Closes #17771.
Closes #17816.
Closes #17897.
Closes #17905.
Closes #18188.
Closes #18232.
Closes #18345.
Closes #18389.
Closes #18400.
Closes #18502.
Closes #18611.
Closes #18783.
Closes #19009.
Closes #19081.
Closes #19098.
Closes #19127.
Closes #19135.
@ghost
Copy link

ghost commented Feb 9, 2015

Hmm, this should not have been closed. I made a typo when preparing #19780.

@ghost ghost reopened this Feb 9, 2015
@goffrie
Copy link
Contributor

goffrie commented Feb 19, 2015

Erm, wasn't this already closed long ago by ac1a270?

@ghost
Copy link

ghost commented Feb 19, 2015

@goffrie It was, my bad! Thanks. :)

@ghost ghost closed this as completed Feb 19, 2015
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this issue Oct 11, 2022
@bors
Auto merge of rust-lang#13324 - Veykril:trait-impl-completion, r=Veykril
f88293f 
Fix trait impl item completions using macro file text ranges

Fixes rust-lang/rust-analyzer#13323
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 24, 2024
@bors
Auto merge of rust-lang#13324 - WeiTheShinobi:single_match, r=dswij
bcf528b 
[`single_match`, `single_match_else`] fix suggestion when match irrefutable

fixes rust-lang#13012

changelog:[`single_match`, `single_match_else`]: fix suggestion when `match` irrefutable
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-parser Area: The parsing of Rust source code to an AST P-medium Medium priority
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Add tests for E-needstest issues
3 participants
@alexcrichton @pnkfelix @goffrie