Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for release notes of #130843: Tracking Issue for #![feature(const_float_methods)] #133383

Open
3 tasks
rustbot opened this issue Nov 23, 2024 · 2 comments
Labels
A-const-eval Area: Constant evaluation (MIR interpretation) relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. WG-const-eval Working group: Const evaluation

Comments

@rustbot
Copy link
Collaborator

rustbot commented Nov 23, 2024

This issue tracks the release notes text for #130843.

Steps

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
  • Issue is nominated for release team review of clarity for wider audience.
  • Release team includes text in release notes/blog posts.

Release notes text

The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).

# Libraries
- [Const-stabilize some float methods gated behind `const_float_methods`.](https://github.com/rust-lang/rust/issues/130843)

Tip

Use the previous releases categories to help choose which one(s) to use.
The category will be de-duplicated with all the other ones by the release team.

More than one section can be included if needed.

Release blog section

If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
Otherwise leave it empty.

cc @eduardosm -- origin issue/PR authors and assignees for starting to draft text

@rustbot rustbot added A-const-eval Area: Constant evaluation (MIR interpretation) relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. WG-const-eval Working group: Const evaluation needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Nov 23, 2024
@jieyouxu jieyouxu added T-lang Relevant to the language team, which will review and decide on the PR/issue. and removed T-lang Relevant to the language team, which will review and decide on the PR/issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Nov 23, 2024
@jieyouxu jieyouxu closed this as not planned Won't fix, can't repro, duplicate, stale Nov 23, 2024
@jieyouxu jieyouxu reopened this Nov 23, 2024
@jieyouxu
Copy link
Member

Stabilization PR: #133389

@jieyouxu
Copy link
Member

(Probably need to remove this entry in favor of exhaustively listing out the const-stabilized APIs)

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Nov 24, 2024
…thods, r=RalfJung

Stabilize `const_float_methods`

Tracking issue: rust-lang#130843
Relnotes: rust-lang#133383

Stabilized const API:

```rust
// in `core`
impl f32/f64 {
    pub const fn recip(self) -> Self;
    pub const fn to_degrees(self) -> Self;
    pub const fn to_radians(self) -> Self;
    pub const fn max(self, other: Self) -> Self;
    pub const fn min(self, other: Self) -> Self;
    pub const fn clamp(self, min: Self, max: Self) -> Self;
    pub const fn abs(self) -> Self;
    pub const fn signum(self) -> Self;
    pub const fn copysign(self, sign: Self) -> Self;
}
```

Closes rust-lang#130843

r? libs-api

cc `@RalfJung` -- I think the way const-stability attributes work have change a bit since the last time a wrote a const-stabilization PR, please make sure I got them right.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Nov 24, 2024
Rollup merge of rust-lang#133389 - eduardosm:stabilize-const_float_methods, r=RalfJung

Stabilize `const_float_methods`

Tracking issue: rust-lang#130843
Relnotes: rust-lang#133383

Stabilized const API:

```rust
// in `core`
impl f32/f64 {
    pub const fn recip(self) -> Self;
    pub const fn to_degrees(self) -> Self;
    pub const fn to_radians(self) -> Self;
    pub const fn max(self, other: Self) -> Self;
    pub const fn min(self, other: Self) -> Self;
    pub const fn clamp(self, min: Self, max: Self) -> Self;
    pub const fn abs(self) -> Self;
    pub const fn signum(self) -> Self;
    pub const fn copysign(self, sign: Self) -> Self;
}
```

Closes rust-lang#130843

r? libs-api

cc `@RalfJung` -- I think the way const-stability attributes work have change a bit since the last time a wrote a const-stabilization PR, please make sure I got them right.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-const-eval Area: Constant evaluation (MIR interpretation) relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-lang Relevant to the language team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. WG-const-eval Working group: Const evaluation
Projects
None yet
Development

No branches or pull requests

2 participants