Skip to content

Add debug representation of function types #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jdm opened this issue Dec 19, 2011 · 1 comment
Closed

Add debug representation of function types #1341

jdm opened this issue Dec 19, 2011 · 1 comment
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)

Comments

@jdm
Copy link
Contributor

jdm commented Dec 19, 2011

No description provided.

@ghost ghost assigned jdm Apr 12, 2012
@nikomatsakis
Copy link
Contributor

Still relevant.

@michaelwoerister michaelwoerister mentioned this issue Aug 29, 2013
Closed
bors added a commit that referenced this issue Aug 31, 2013
@bors
auto merge of #8855 : michaelwoerister/rust/captured_vars, r=jdm
16024c5 
This pull request includes
* support for variables captured in closures*,
* a fix for issue #8512: arguments of non-immediate type (structs, tuples, etc) passed by value can now be accessed correctly in GDB. (I managed to fix this by using `llvm::DIBuilder::createComplexVariable()`. However, I am not sure if this relies on unstable implementation details of LLVM's debug info handling. I'll try to clarify this on the LLVM mailing list).
* simplification of the `debuginfo` module's public interface: the caller of functions like `create_local_var_metadata()` doesn't have to know and catch all cases when it mustn't call the function,
* a cleanup refactoring with unified handling for locals, [self] arguments, captured variables, and match bindings,
* and proper span information for self arguments.

\* However, see comment at https://github.com/michaelwoerister/rust/blob/1d916ace136a27e354d73d65f488603c65f65bd2/src/test/debug-info/var-captured-in-nested-closure.rs#L62 . This is the same problem as with the fix for issue #8512 above: We are probably using `llvm.dbg.declare` in an unsupported way that works today but might not work after the next LLVM update.

Cheers,
Michael

Fixes #8512
Fixes #1341
@bors bors closed this as completed in 45c3ca7 Sep 4, 2013
@jdm jdm removed their assignment Jun 16, 2014
bjorn3 added a commit to bjorn3/rust that referenced this issue Jan 24, 2023
@bjorn3
Merge pull request rust-lang#1341 from bjorn3/build_sysroot_cleanup
611c518 
Refactor sysroot building
coastalwhite pushed a commit to coastalwhite/rust that referenced this issue Aug 5, 2023
@Amanieu
Fix undefined behavior in SSE4.2 test (rust-lang#1341)
df8f172
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

debuginfo: Captured variables and large pass-by-value arguments michaelwoerister/rust
2 participants
@jdm @nikomatsakis