-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
put the list of tests run in CI behind a ::group
#134910
Comments
I'd like to take a shot at implementing this if no one else is already working on it. @rustbot claim |
do you have an example? |
@matthiaskrgr the plain-text log IME loads quite fast and the jump-to-bottom usually works. However the plain-text log has a bunch of unrendered color codes which makes it very annoying to look at, so sometimes you look at the (web) interface. The web interface can be hard to scroll down because it doesn't load all at once... |
When I curl the plaintext into a terminal, I actually get the fully colored logs displayed as stdout, as the color control chars are dumped straight into the terminal which then renders as it always would. The web interface is broken as often I can't even scroll down far enough to see the error 😆 |
Not directly related to the tests but I noticed that the Docker cache hash key input (pre-hashed) is getting dumped here Line 80 in c156614
This ends up taking up a pretty good chunk of the non-collapsed logs. Few examples pulled at random from the Actions tab
I think we could probably add a |
…obzol ci: Cleanup docker build logs in CI Cleaning up the CI logs to make reviewing CI failures easier. This PR adds a `::group` around the docker tag hash input which is pretty large (250+ lines) and is probably not relevant for most people. Related to rust-lang#134910 , see this [comment](rust-lang#134910 (comment))
Rollup merge of rust-lang#134924 - ranger-ross:cleanup-ci-output, r=Kobzol ci: Cleanup docker build logs in CI Cleaning up the CI logs to make reviewing CI failures easier. This PR adds a `::group` around the docker tag hash input which is pretty large (250+ lines) and is probably not relevant for most people. Related to rust-lang#134910 , see this [comment](rust-lang#134910 (comment))
I did some research on this and I have a few thoughts. Currently we already have a I am thinking we instead create a new test report format in Current format
Proposed format
Another idea would be to add a job summary with the failed tests + logs. |
right now, scrolling through a CI log to find a failed test takes quite a while. it would be nice to hide all the successful tests by default so that the failed tests show up right away. we do something similar already for compiling.
this may be kinda tricky because compiletest needs to print this after all the tests have run, but before libtest prints the test report. there might be a hook for this and there might not.
@rustbot label A-contributor-roadblock A-testsuite
The text was updated successfully, but these errors were encountered: