Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax-phase crates are always linked against #13495

Closed
sfackler opened this issue Apr 13, 2014 · 0 comments · Fixed by #13496
Closed

Syntax-phase crates are always linked against #13495

sfackler opened this issue Apr 13, 2014 · 0 comments · Fixed by #13496
Labels
A-linkage Area: linking into static, shared libraries and binaries A-syntaxext Area: Syntax extensions

Comments

@sfackler
Copy link
Member

It appears that this is was caused by #13384.

#![feature(phase)]
#[phase(syntax)]
extern crate fourcc;

fn main() { fourcc!("1234"); }
~ ❯ rustc -Z lto test.rs
error: could not find rlib for: `fourcc`

cc @alexcrichton
alexcrichton added a commit to alexcrichton/rust that referenced this issue Apr 13, 2014
@alexcrichton
rustc: Don't link in syntax extensions
e163ab2 
This bug was introduced in rust-lang#13384 by accident, and this commit continues the
work of rust-lang#13384 by finishing support for loading a syntax extension crate without
registering it with the local cstore.

Closes rust-lang#13495
@alexcrichton alexcrichton mentioned this issue Apr 13, 2014
Merged
bors added a commit that referenced this issue Apr 14, 2014
@bors
auto merge of #13496 : alexcrichton/rust/issue-13495, r=sfackler
168b2d1 
This bug was introduced in #13384 by accident, and this commit continues the
work of #13384 by finishing support for loading a syntax extension crate without
registering it with the local cstore.

Closes #13495
Dylan-DPC pushed a commit to Dylan-DPC/rust that referenced this issue Nov 1, 2022
@bors
Auto merge of rust-lang#13496 - rust-lang:lnicola-patch-1, r=jonas-sc…
d022e0e 
…hievink

internal: Clarify feature policy

CC rust-lang#13495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries A-syntaxext Area: Syntax extensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustc: Don't link in syntax extensions alexcrichton/rust
1 participant
@sfackler