PathSet prefix matching breaks cli path filter consumption order
#135022
Labels
C-bug
Category: This is a bug.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Comments
jieyouxu
added
C-bug
rustbot
added
the
needs-triage
jieyouxu
removed
the
needs-triage
bors
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 2, 2025
bootstrap: flip `compile::Rustc` vs `compile::Assemble` The `PathSet` prefix matching unfortunately also has implications for `./x build compiler --stage 0`, because the path filter `"compiler"` gets consumed by `compile::Rustc` step first after `PathSet` prefix matching, whereas before `PathSet` prefix matching, `compile::Rustc` would not have consumed `"compiler"`. This merely papers over rust-lang#134970 to unblock contributors from using `./x build compiler --stage 0`. The `PathSet` prefix matching behavior is tracked in rust-lang#135022. Closes rust-lang#134970.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Jan 3, 2025
…ouxu refactor bootstrap path resolution Previously we removed paths as soon as we found the first intersection, which made it impossible to find other intersecting paths (and that is the reason of rust-lang#135022). This patch changes that by marking the intersecting paths instead, so we can collect them all and remove them together when needed. Which means, `x build compiler` would compile anything that ends or starts with `"compiler"` instead of picking the first matching `Step` from `builder::get_step_descriptions`. Fixes rust-lang#135022
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Jan 4, 2025
Rollup merge of rust-lang#135058 - onur-ozkan:path-resolution, r=jieyouxu refactor bootstrap path resolution Previously we removed paths as soon as we found the first intersection, which made it impossible to find other intersecting paths (and that is the reason of rust-lang#135022). This patch changes that by marking the intersecting paths instead, so we can collect them all and remove them together when needed. Which means, `x build compiler` would compile anything that ends or starts with `"compiler"` instead of picking the first matching `Step` from `builder::get_step_descriptions`. Fixes rust-lang#135022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#133492 changed
PathSetmatching to also admit path prefixes, in addition to the previously-admitted suffixes. Unfortunately, this breaks howdescribe!handles someSteps. For the typical non-ShouldRun::suite_pathStep, it will consume a path filter like"compiler"when eligible.#133492 allowing prefix matching changed which
Steps is permitted to "eat" the path filter first, which broke./x test compiler --stage 0and./x build compiler --stage 0due to the respectiveStepregistration order and whichSteps get to consume the path filter first:./x test compileronly runs unit tests forrustc_codegen_cranelift#134916./x build compiler --stage 0reports success, but it shouldn't: deleting method used in another crate does not cause compilation to fail #134970cc discussions at https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Mismatch.20between.20arg-filter.20vs.20.60--exclude.60.20filter.
The text was updated successfully, but these errors were encountered: