-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Description
with the removal of --disable-minification
, i was under the impression that the reccommended workflow is to symlink files in the static.files
directory to their origin locations.
this workaround works completly fine when used on regular docs, however, it causes serious problems when trying to use it for the static.files
in the rustdoc-js
dirs.
reproduction steps:
rm -r build/host/test/rustdoc-js
./x test --stage 1 tests/rustdoc-js/type-parameters.rs
(any unit test should work)ln -f src/librustdoc/html/static/js/search.js build/host/test/rustdoc-js/type-parameters/static.files/search-*.js
./x test --stage 1 tests/rustdoc-js/type-parameters.rs
(again)
this will result in src/librustdoc/html/static/js/search.js
becoming minified.
personally i think we should just bring back the --disable-minification
option as perma-unstable. that or we should have a canonical implementation of this symlink hack integrated into bootstrap.
Metadata
Metadata
Assignees
Labels
A-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.Category: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.