Skip to content

Overload visit_qpath instead of using visit_pat in rustdoc "jump to def" implementation #135485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GuillaumeGomez opened this issue Jan 14, 2025 · 0 comments · May be fixed by #135771
Open

Overload visit_qpath instead of using visit_pat in rustdoc "jump to def" implementation #135485

GuillaumeGomez opened this issue Jan 14, 2025 · 0 comments · May be fixed by #135771
Assignees
@GuillaumeGomez
Labels
A-link-to-definition rustdoc --generate-link-to-definition nightly-only feature C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

It's a follow-up of this discussion where @fmease suggested an improvement to the code.

Assigning myself to do it. :)
@GuillaumeGomez GuillaumeGomez added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 14, 2025
@GuillaumeGomez GuillaumeGomez self-assigned this Jan 14, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 14, 2025
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 14, 2025
@GuillaumeGomez GuillaumeGomez changed the title Overload visit_qself instead of using visit_pat in rustdoc "jump to def" implementation Overload visit_qpath instead of using visit_pat in rustdoc "jump to def" implementation Jan 20, 2025
@GuillaumeGomez GuillaumeGomez linked a pull request Jan 20, 2025 that will close this issue
Open
bors added a commit to rust-lang-ci/rust that referenced this issue Jan 20, 2025
@bors
Auto merge of rust-lang#135771 - GuillaumeGomez:jump-to-def-perf, r=<…
4f36aac 
…try>

[PERF for "jump to def"] Re-enable "jump to def" feature on rustc docs

This PR is NOT meant to be merged. `@fmease` and I are using it to check perfs on the "jump to def" feature.

Used for rust-lang#135485.

r? `@fmease`
@fmease fmease added the A-link-to-definition rustdoc --generate-link-to-definition nightly-only feature label Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-link-to-definition rustdoc --generate-link-to-definition nightly-only feature C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[rustdoc] Add support for associated items in "jump to def" feature GuillaumeGomez/rust
4 participants
@GuillaumeGomez @fmease @jieyouxu @rustbot