Skip to content

-C split-debuginfo={off,packed,unpacked} is (effectively) untested on windows-msvc and windows-gnu (well, windows generally) #135531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jieyouxu opened this issue Jan 15, 2025 · 0 comments
Open

-C split-debuginfo={off,packed,unpacked} is (effectively) untested on windows-msvc and windows-gnu (well, windows generally) #135531

jieyouxu opened this issue Jan 15, 2025 · 0 comments
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. O-windows-gnu Toolchain: GNU, Operating system: Windows O-windows-msvc Toolchain: MSVC, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Jan 15, 2025 •
edited
Loading

tests/run-make/split-debuginfo has this:

rust/tests/run-make/split-debuginfo/Makefile

Lines 34 to 38 in 2776bdf

ifdef IS_WINDOWS
# Windows only supports packed debuginfo - nothing to test.
off:
packed:
unpacked:

Which lumps windows-msvc and windows-gnu together, and also doesn't test anything on windows altogether.

Noticed while working on porting split-debuginfo to rmake.rs.

If this is tested somewhere else, well, it's clearly not in this run-make test.
@jieyouxu jieyouxu added A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. O-windows-gnu Toolchain: GNU, Operating system: Windows O-windows-msvc Toolchain: MSVC, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 15, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 15, 2025
@jieyouxu jieyouxu added E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 15, 2025
@jieyouxu jieyouxu changed the title -C split-debuginfo={off,packed,unpacked} is (effectively) untested on windows-msvc and windows-gnu -C split-debuginfo={off,packed,unpacked} is (effectively) untested on windows-msvc and windows-gnu (well, windows generally) Jan 15, 2025
@jieyouxu jieyouxu mentioned this issue Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot. O-windows-gnu Toolchain: GNU, Operating system: Windows O-windows-msvc Toolchain: MSVC, Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jieyouxu @rustbot