Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ty_vec, avoiding vstore #13554

Closed
nrc opened this issue Apr 16, 2014 · 0 comments · Fixed by #13636
Closed

Refactor ty_vec, avoiding vstore #13554

nrc opened this issue Apr 16, 2014 · 0 comments · Fixed by #13636

Comments

@nrc
Copy link
Member

nrc commented Apr 16, 2014

So vector types are represented as pointer types around a vector, rather than having the pointer type embedded in the vector type.
@nrc nrc mentioned this issue Apr 16, 2014
Closed
23 tasks
nrc added a commit to nrc/rust that referenced this issue Apr 20, 2014
@nrc
Refactor ty_vec represent &[T] as &([T])
37306c1 
Refactores all uses of ty_vec and associated things to remove the vstore abstraction (still used for strings, for now). Pointers to vectors are stored as ty_rptr or ty_uniq wrapped around a ty_vec. There are no user-facing changes. Existing behaviour is preserved by special-casing many instances of pointers containing vectors. Hopefully with DST most of these hacks will go away. For now it is useful to leave them hanging around rather than abstracting them into a method or something.

Closes rust-lang#13554.
@nrc nrc mentioned this issue Apr 20, 2014
Merged
bors added a commit that referenced this issue Apr 20, 2014
@bors
auto merge of #13636 : nick29581/rust/ty_vec, r=pcwalton
02081e7 
Refactors all uses of ty_vec and associated things to remove the vstore abstraction (still used for strings, for now). Pointers to vectors are stored as ty_rptr or ty_uniq wrapped around a ty_vec. There are no user-facing changes. Existing behaviour is preserved by special-casing many instances of pointers containing vectors. Hopefully with DST most of these hacks will go away. For now it is useful to leave them hanging around rather than abstracting them into a method or something.

Closes #13554.
flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 18, 2024
@bors
Auto merge of rust-lang#13554 - ageorgou:doc-links, r=xFrednet
ccb30bf 
Documentation fixes

- In [the page describing the lints](https://rust-lang.github.io/rust-clippy/master/index.html), the View Source links are incorrect. This PR removes the extra segment causing them to fail.
  - Example before: https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/clippy_lints/src/absolute_paths.rs#L13
  - Example after: https://github.com/rust-lang/rust-clippy/blob/master/clippy_lints/src/absolute_paths.rs#L13
  - I think this was introduced in rust-lang#13269.
  - I've only checked a few of the lints with the new template, but from what I can tell the metadata is generated in the same way for all of them. The `id_location` contains the full path of the lint declaration in the repository, which is why `clippy_lints` was repeated in the URL.
- Separately, fixing a typo in the explanation of `unnecessary_get_then_check`.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor ty_vec - represent &[T] as &([T]) nrc/rust
1 participant
@nrc