Skip to content

clean up and unify logic used by rustdoc-js and rustdoc-js-std test suites. #135597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lolbinarycat opened this issue Jan 16, 2025 · 0 comments
Open

clean up and unify logic used by rustdoc-js and rustdoc-js-std test suites. #135597

lolbinarycat opened this issue Jan 16, 2025 · 0 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@lolbinarycat
Copy link
Contributor

I cannot find the code that actually runs rustdoc on the rustdoc-js/*.rs files, and for some unknown reason, that code is not actually getting run (leading to issues about search-index.js not being found).

This code is quite a mess, rustdoc-js-std seems to be mostly implemented in bootstrap, while rustdoc-js is mostly implemented in compiletest.

This discrepancy leads to an ever increasing number of discrepancies between the exact behavior of the two test suites. Rather than trying to patch these up one by one, I would rather we take a big picture approach.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 16, 2025
@jieyouxu jieyouxu added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 16, 2025
@lolbinarycat lolbinarycat mentioned this issue Jan 17, 2025
Closed
@onur-ozkan onur-ozkan marked this as a duplicate of #135603 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lolbinarycat @jieyouxu @rustbot