Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add src/librustdoc and src/rustdoc-json-types to RUSTC_IF_UNCHANGED_ALLOWED_PATHS #135650

Closed
lolbinarycat opened this issue Jan 17, 2025 · 4 comments · Fixed by #135654
Closed
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@lolbinarycat
Copy link
Contributor

this constant (in src/bootstrap/src/core/config/config.rs) list what paths can be changed without affecting the produced rustc binary.

since rustdoc isn't embedded in the compiler, shouldn't these be on the list?

@lolbinarycat lolbinarycat added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 17, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 17, 2025
@onur-ozkan onur-ozkan added C-discussion Category: Discussion or questions that doesn't represent real issues. and removed C-enhancement Category: An issue proposing an enhancement or a PR with one. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 17, 2025
@Noratrieb
Copy link
Member

Noratrieb commented Jan 17, 2025

I think this would be sound, yes. Given that working on rustdoc is a major use case for download-rustc, it makes a lot of sense to add them to the list (a list that should generally be kept as minimal as possible).

@onur-ozkan
Copy link
Member

We decided to start with smallest possible list, there are various paths that can be included in the list.

Also, I would share these open-ended topics/questions on Zulip so that people who might have an opinion on it have a better chance of seeing it.

@lolbinarycat
Copy link
Contributor Author

I don't open these for open ended discussion. I open them mostly as a reminder to myself (since I usually run into these things when I'm doing something else), and also partially to allow feedback from team members, such as if there are any objections to the change.

@onur-ozkan
Copy link
Member

onur-ozkan commented Jan 17, 2025

When it ends with a question and expecting some feedback from others (there are some people that have interest in the behavior of the CI rustc if-unchanged logic), it seems quite open-ended to me. Anyway...

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 17, 2025
…nur-ozkan

add src/librustdoc and src/rustdoc-json-types to RUSTC_IF_UNCHANGED_ALLOWED_PATHS

fixes rust-lang#135650

r? `@onur-ozkan`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jan 18, 2025
…nur-ozkan

add src/librustdoc and src/rustdoc-json-types to RUSTC_IF_UNCHANGED_ALLOWED_PATHS

fixes rust-lang#135650

r? ``@onur-ozkan``
@bors bors closed this as completed in d58540d Jan 18, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 18, 2025
Rollup merge of rust-lang#135654 - lolbinarycat:bootstrap-135650, r=onur-ozkan

add src/librustdoc and src/rustdoc-json-types to RUSTC_IF_UNCHANGED_ALLOWED_PATHS

fixes rust-lang#135650

r? ``@onur-ozkan``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@lolbinarycat @onur-ozkan @rustbot @Noratrieb and others