-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add src/librustdoc
and src/rustdoc-json-types
to RUSTC_IF_UNCHANGED_ALLOWED_PATHS
#135650
Comments
I think this would be sound, yes. Given that working on rustdoc is a major use case for download-rustc, it makes a lot of sense to add them to the list (a list that should generally be kept as minimal as possible). |
We decided to start with smallest possible list, there are various paths that can be included in the list. Also, I would share these open-ended topics/questions on Zulip so that people who might have an opinion on it have a better chance of seeing it. |
I don't open these for open ended discussion. I open them mostly as a reminder to myself (since I usually run into these things when I'm doing something else), and also partially to allow feedback from team members, such as if there are any objections to the change. |
When it ends with a question and expecting some feedback from others (there are some people that have interest in the behavior of the CI rustc if-unchanged logic), it seems quite open-ended to me. Anyway... |
…nur-ozkan add src/librustdoc and src/rustdoc-json-types to RUSTC_IF_UNCHANGED_ALLOWED_PATHS fixes rust-lang#135650 r? `@onur-ozkan`
…nur-ozkan add src/librustdoc and src/rustdoc-json-types to RUSTC_IF_UNCHANGED_ALLOWED_PATHS fixes rust-lang#135650 r? ``@onur-ozkan``
Rollup merge of rust-lang#135654 - lolbinarycat:bootstrap-135650, r=onur-ozkan add src/librustdoc and src/rustdoc-json-types to RUSTC_IF_UNCHANGED_ALLOWED_PATHS fixes rust-lang#135650 r? ``@onur-ozkan``
this constant (in
src/bootstrap/src/core/config/config.rs
) list what paths can be changed without affecting the producedrustc
binary.since rustdoc isn't embedded in the compiler, shouldn't these be on the list?
The text was updated successfully, but these errors were encountered: