Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execution time should not be part of checked test output #135660

Closed
matthiaskrgr opened this issue Jan 17, 2025 · 0 comments · Fixed by #135736
Closed

execution time should not be part of checked test output #135660

matthiaskrgr opened this issue Jan 17, 2025 · 0 comments · Fixed by #135736
Assignees
@fmease
Labels
A-doctests Area: Documentation tests, run by rustdoc A-rustdoc-ui Area: Rustdoc UI (generated HTML) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. I-flaky-test Issue: A test is flaky/unreliable/spuriously fails T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@matthiaskrgr
Copy link
Member

rust/tests/rustdoc-ui/doctest/doctest-no-run-invalid-langstring-124577.stdout

Line 4 in bcd0683

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

I had this one fail locally because it took 0.01s instead of 0.00s which is checked against in the test output 😆
@matthiaskrgr matthiaskrgr added A-doctests Area: Documentation tests, run by rustdoc A-testsuite Area: The testsuite used to check the correctness of rustc I-flaky-test Issue: A test is flaky/unreliable/spuriously fails labels Jan 17, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 17, 2025
@matthiaskrgr matthiaskrgr changed the title execution time should not be part of test output execution time should not be part of checked test output Jan 17, 2025
@matthiaskrgr matthiaskrgr added the A-rustdoc-ui Area: Rustdoc UI (generated HTML) label Jan 17, 2025
@jieyouxu jieyouxu added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 17, 2025
@fmease fmease self-assigned this Jan 19, 2025
@fmease fmease mentioned this issue Jan 19, 2025
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jan 19, 2025
@GuillaumeGomez
Rollup merge of rust-lang#135736 - fmease:rustdoc-fix-flaky-test, r=G…
f9c28e9 
…uillaumeGomez

rustdoc: Fix flaky doctest test

Fixes rust-lang#135660.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jan 19, 2025
@GuillaumeGomez
Rollup merge of rust-lang#135736 - fmease:rustdoc-fix-flaky-test, r=G…
8bd35b5 
…uillaumeGomez

rustdoc: Fix flaky doctest test

Fixes rust-lang#135660.
@bors bors closed this as completed in 64768c5 Jan 20, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 20, 2025
@rust-timer
Unrolled build for rust-lang#135736
bf663d2 
Rollup merge of rust-lang#135736 - fmease:rustdoc-fix-flaky-test, r=GuillaumeGomez

rustdoc: Fix flaky doctest test

Fixes rust-lang#135660.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmease fmease

Labels
A-doctests Area: Documentation tests, run by rustdoc A-rustdoc-ui Area: Rustdoc UI (generated HTML) A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. I-flaky-test Issue: A test is flaky/unreliable/spuriously fails T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
testing-devex backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: Fix flaky doctest test fmease/rust
4 participants
@matthiaskrgr @fmease @jieyouxu @rustbot