Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI test multiple-reprs fails on targets that set c-enum-min-bits #135777

Closed
japaric opened this issue Jan 20, 2025 · 0 comments · Fixed by #135778
Closed

UI test multiple-reprs fails on targets that set c-enum-min-bits #135777

japaric opened this issue Jan 20, 2025 · 0 comments · Fixed by #135778
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@japaric
Copy link
Member

japaric commented Jan 20, 2025

This part of the test assumes that the enum's discriminant has a size of c_int which is true for most targets but not for targets that set TargetOptions.c_enum_min_bits like thumbv7em-none-eabihf. The multiple-reprs test fails when run on those target.

affected revision: b5741a3

I'll submit a PR fixing the test on those targets shortly
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jan 20, 2025
@japaric japaric mentioned this issue Jan 20, 2025
Merged
@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jan 21, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Feb 14, 2025
@workingjubilee
Rollup merge of rust-lang#135778 - ferrocene:ja-gh135777, r=workingju…
a28ed1e 
…bilee

account for `c_enum_min_bits` in `multiple-reprs` UI test

fixes rust-lang#135777
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#135778 - ferrocene:ja-gh135777, r=workingju…
4b13dfd 
…bilee

account for `c_enum_min_bits` in `multiple-reprs` UI test

fixes rust-lang#135777
@bors bors closed this as completed in a710e1f Feb 14, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 14, 2025
@rust-timer
Unrolled build for rust-lang#135778
6ae2f37 
Rollup merge of rust-lang#135778 - ferrocene:ja-gh135777, r=workingjubilee

account for `c_enum_min_bits` in `multiple-reprs` UI test

fixes rust-lang#135777
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

account for c_enum_min_bits in multiple-reprs UI test ferrocene/rust
3 participants
@japaric @jieyouxu @rustbot