-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Labels
A-panicArea: Panicking machineryArea: Panicking machineryA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.Call for participation: Medium difficulty. Experience needed to fix: Intermediate.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
There are a bunch of tests that say ignore-wasm
or ignore-emscripten
or ignore-$platform
with a comment "no panic support" or "no panic". It would be good to audit them and see if one or more of the following capability-based conditional test execution directives can be used instead:
//@ needs-unwind
//@ needs-threads
//@ needs-subprocess
1
If those are not sufficient, it would be good to improve the ignore reason anyway.
Footnotes
-
I'm still working on implementing this directive over at compiletest: add a
needs-subprocess
directive #128295. ↩
Metadata
Metadata
Assignees
Labels
A-panicArea: Panicking machineryArea: Panicking machineryA-testsuiteArea: The testsuite used to check the correctness of rustcArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-mediumCall for participation: Medium difficulty. Experience needed to fix: Intermediate.Call for participation: Medium difficulty. Experience needed to fix: Intermediate.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.