-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std net test base_port
logic seems strange/outdated?
#136633
Labels
A-io
Area: `std::io`, `std::fs`, `std::net` and `std::path`
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Comments
base_port
logic seems strange/outdated?base_port
logic seems strange/outdated?
AFAIK this was never modified since |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this issue
Feb 7, 2025
Remove outdated `base_port` calculation in std net test This was never modified since `std::net` was originally introduced in 395709c, when at that time, each CI runner was running multiple jobs concurrently. This seems to have originally caused issues with jobs fighting over the same ports. This is not the case in the current CI infrastructure, so remove this relic in favor of a simple constant base port number. I double-checked `19600` and nearby port numbers, and this isn't a well-known port number AFAICT[^1]. Closes rust-lang#136633. [^1]: At the time of writing.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
Feb 8, 2025
Rollup merge of rust-lang#136635 - jieyouxu:base_port, r=joboet Remove outdated `base_port` calculation in std net test This was never modified since `std::net` was originally introduced in 395709c, when at that time, each CI runner was running multiple jobs concurrently. This seems to have originally caused issues with jobs fighting over the same ports. This is not the case in the current CI infrastructure, so remove this relic in favor of a simple constant base port number. I double-checked `19600` and nearby port numbers, and this isn't a well-known port number AFAICT[^1]. Closes rust-lang#136633. [^1]: At the time of writing.
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this issue
Mar 11, 2025
Remove outdated `base_port` calculation in std net test This was never modified since `std::net` was originally introduced in 395709c, when at that time, each CI runner was running multiple jobs concurrently. This seems to have originally caused issues with jobs fighting over the same ports. This is not the case in the current CI infrastructure, so remove this relic in favor of a simple constant base port number. I double-checked `19600` and nearby port numbers, and this isn't a well-known port number AFAICT[^1]. Closes rust-lang#136633. [^1]: At the time of writing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-io
Area: `std::io`, `std::fs`, `std::net` and `std::path`
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
I was running
./x test library/std --stage 0
locally, and a bunch of std TCP tests were failing because apparently my VPN software is already using one of the ports that the TCP tests were trying to use (this part is user issue).However, while reading the tests it seems like
base_port
(which I think is transitively used by TCP tests) is doing some kind of... CI job detection? Which has been outdated for many years? Not sure what this is supposed to be.rust/library/std/src/net/test.rs
Lines 34 to 60 in 5958825
The text was updated successfully, but these errors were encountered: