Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for better testing for dist artifacts #136822

Open
jieyouxu opened this issue Feb 10, 2025 · 6 comments
Open

Tracking issue for better testing for dist artifacts #136822

jieyouxu opened this issue Feb 10, 2025 · 6 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@jieyouxu
Copy link
Member

jieyouxu commented Feb 10, 2025

This is a tracking issue for improving the testing for dist artifacts (including but not limited to, dist compilers and dist components like rustc-src).

As of the time of writing, much of dist components are not really tested or exercised in a basic way (modulo tests through opt-dist, but not all dist artifacts go through opt-dist).

Example regressions

@jieyouxu jieyouxu added A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 10, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 10, 2025
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 10, 2025
@jieyouxu
Copy link
Member Author

jieyouxu commented Feb 10, 2025

I know that x86_64-unknown-linux-gnu and aarch64-unknown-linux-gnu dist artifacts do receive some degree of testing due to post-PGO opt-dist tests.

It's the apple and windows dist artifacts that I don't know if are tested at all.

@ChrisDenton
Copy link
Member

Yes I think not testing CI dist artefacts is the default rather than the exception.

@Noratrieb Noratrieb changed the title i686-pc-windows-gnu dist artifacts are not tested dist artifacts are generally not tested Feb 10, 2025
@Noratrieb
Copy link
Member

If we call the issue like that, no one will bother to ever fix it of course. But this does actually affect more than just i686-pc-windows-gnu so someone might actually care.

@jieyouxu
Copy link
Member Author

@Noratrieb
Copy link
Member

A bootstrap PR broke tools completely after dist, #137469. Smoke tests would have prevented that as well.

@jieyouxu
Copy link
Member Author

See also #138306. That is a case where the rustc-src dist component broke because we tried to use workspace lint table of the rust-lang/rust root manifest, which is not shipped as part of this dist component, so compiler sources no longer build on their own. I didn't catch this nor did the PR author because we would've needed to inspect the rustc-src dist component...

@jieyouxu jieyouxu added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Mar 18, 2025
@jieyouxu jieyouxu changed the title dist artifacts are generally not tested Tracking issue for better testing for dist artifacts Mar 18, 2025
@jieyouxu jieyouxu added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC and removed C-bug Category: This is a bug. labels Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants