Cannot pass flags to bootstrap links after #133092 #136984
Labels
C-bug
Category: This is a bug.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Comments
aeubanks
added
C-bug
rustbot
added
the
needs-triage
onur-ozkan
removed
the
needs-triage
|
cc @madsmtm |
|
We currently cannot build Rust for Chromium's toolchain due to this regression. If it takes a while to resolve this, can we revert #133092 in the meantime to keep HEAD functional? |
|
Sorry, should've commented here earlier. I'm working on a fix in |
|
Another workaround in the meantime would be for you to pass |
|
the |
aarongable
pushed a commit
to chromium/chromium
that referenced
this issue
Feb 14, 2025
…for upstream issue And remove upstream rust revert. Suggested at rust-lang/rust#136984 (comment). Tested locally that removing the revert causes the build to break and the CFLAGS workaround fixes it again, so there shouldn't be a need for a new package. Bug: 395891130 Change-Id: Iae7fc9e518e6ff955a09385f5443fac54ca6a015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6269907 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1420683}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
(https://crbug.com/395891130 is the bug on our side)
After #133092, flags we set via
CFLAGS/CXXFLAGS/LDFLAGS/RUSTFLAGS_BOOTSTRAP/RUSTFLAGS_NOT_BOOTSTRAPno longer get passed to bootstrap links, resulting in the--sysroot=flag we pass not taking effect (they get passed to the compiles but not to the link) and getting weird link errors. I've commented on that PR with the location of which change breaks us. Looking at the PR, it seems like it's not possible to pass arbitrary link flags anymore, which seems like a big regression.Command used
Expected behaviour
Build succeeds
Actual behaviour
Operating system
Debian
HEAD
6171d94
Additional context
with
RUST_BACKTRACE=1and-vThe text was updated successfully, but these errors were encountered: