Skip to content

"Implementations on foreign types" is sorted in trivial lexographic order in sidebar #137098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lolbinarycat opened this issue Feb 15, 2025 · 0 comments · Fixed by #137106
Closed

"Implementations on foreign types" is sorted in trivial lexographic order in sidebar #137098

lolbinarycat opened this issue Feb 15, 2025 · 0 comments · Fixed by #137106
Assignees
@chenyukang
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Comments

@lolbinarycat
Copy link
Contributor

this can look quite awkward when numeric types are involved, and could be improved by using a comparison function that is number-aware, such as the one used by sort -g.

example of the awkwardness this can cause: https://docs.rs/bitvec/latest/bitvec/store/trait.BitStore.html
@lolbinarycat lolbinarycat added the A-rustdoc-ui Area: Rustdoc UI (generated HTML) label Feb 15, 2025
@rustbot rustbot added T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 15, 2025
@fmease fmease added C-enhancement Category: An issue proposing an enhancement or a PR with one. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 15, 2025
@chenyukang chenyukang self-assigned this Feb 16, 2025
@chenyukang chenyukang mentioned this issue Feb 16, 2025
Merged
@bors bors closed this as completed in 8ccfd06 Feb 20, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 20, 2025
@rust-timer
Unrolled build for rust-lang#137106
1f4ab4c 
Rollup merge of rust-lang#137106 - chenyukang:yukang-fix-sidebar-sort, r=notriddle

Add customized compare for Link in rustdoc

Maybe some other types in sidebar need to be sorted in this way, maybe add this crate `natord` is ok?

r?  clubby789

Fixes rust-lang#137098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chenyukang chenyukang

Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add customized compare for Link in rustdoc chenyukang/rust
4 participants
@chenyukang @fmease @lolbinarycat @rustbot