Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly docs of std::task::ready! report wrong stabilization version #137141

Closed
paolobarbolini opened this issue Feb 16, 2025 · 2 comments · Fixed by #137320
Closed

Nightly docs of std::task::ready! report wrong stabilization version #137141

paolobarbolini opened this issue Feb 16, 2025 · 2 comments · Fixed by #137320
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-stability Area: `#[stable]`, `#[unstable]` etc. C-bug Category: This is a bug. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@paolobarbolini
Copy link
Contributor

Location

https://doc.rust-lang.org/nightly/std/task/macro.ready.html

Summary

The nightly docs for std::task::ready! report a stabilization version of v1.36, while core::task::ready! correctly reports v1.64.

This doesn't appear for current beta docs and current stable docs
@paolobarbolini paolobarbolini added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Feb 16, 2025
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Feb 16, 2025
@bjorn3
Copy link
Member

bjorn3 commented Feb 16, 2025

Std's mod task contains #[stable(feature = "futures_api", since = "1.36.0")] pub use core::task::*;. I guess rustdoc inherits the stabilization version from the wildcard re-export rather than taking the maximum of the re-export itself and the re-exported type.

@naskya
Copy link
Contributor

naskya commented Feb 16, 2025

I guess it’s supposed to be covered by this test, but apparently it isn’t.

@jieyouxu jieyouxu added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-stability Area: `#[stable]`, `#[unstable]` etc. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 20, 2025
@tapanprakasht tapanprakasht mentioned this issue Feb 20, 2025
Merged
fmease added a commit to fmease/rust that referenced this issue Feb 26, 2025
@fmease
Rollup merge of rust-lang#137320 - tapanprakasht:fix-doc-version-stab…
775c7cf 
…ility, r=notriddle

fix(rustdoc): Fixed stability version in rustdoc

Tries to fix rust-lang#137141
Fixed by adding checks glob exports
@bors bors closed this as completed in ef53922 Feb 26, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 26, 2025
@rust-timer
Unrolled build for rust-lang#137320
9d4a699 
Rollup merge of rust-lang#137320 - tapanprakasht:fix-doc-version-stability, r=notriddle

fix(rustdoc): Fixed stability version in rustdoc

Tries to fix rust-lang#137141
Fixed by adding checks glob exports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-stability Area: `#[stable]`, `#[unstable]` etc. C-bug Category: This is a bug. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rustdoc): Fixed stability version in rustdoc tapanprakasht/rust
5 participants
@paolobarbolini @bjorn3 @jieyouxu @rustbot @naskya