Skip to content

Documentation fonts not currently included with the nightly binary tarballs #13787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alxgnon opened this issue Apr 26, 2014 · 3 comments
Closed
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@alxgnon
Copy link
Contributor

alxgnon commented Apr 26, 2014

The nightly binaries provided on rust-lang.org do not include the fonts 'Fira Sans' and 'Heuristica' that should normally be located within the doc directory. This might be an issue with the build process or the rust buildbot, and could be related to the recent inclusion of these fonts to the local documentation. [https://github.com/mozilla/rust/commit/395d8857d60c66876d41484d6caea05c03882fad]

I'm going to try to identify the underlying problem. I will share my findings in a couple hours.

@alxgnon
Copy link
Contributor Author

alxgnon commented Apr 26, 2014

I tried building documentation with the current nightly version of rustdoc [https://github.com/mozilla/rust/commit/a692e9b1234ff6573b0cfbc39394d9222eb38f81] and sure enough, the fonts are not included even though they are referenced in the CSS. The font falls back to Helvetica Neue in my case.

@tomjakubowski
Copy link
Contributor

Building the nightly's documentation into a Dash docset required some pretty nasty workarounds to make it truly offline: indirect/dash-rust@35fef55. It would be very nice if the WOFF files were included in the output of rustdoc and referenced in the @font-face declaration rather than the assets on rust-lang.org.

@adrientetar
Copy link
Contributor

Sorry for the inconvenience, I believe that #13744 should have fixed this. Please try to rebuild with a recent master.

It is now uploaded on static.rust-lang.org through it will need configuration changes since it gives a 403 just now (see #13593 – repurposed).

tomjakubowski added a commit to tomjakubowski/dash-rust that referenced this issue May 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants