Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiletest should reject true and false as revision names #138663

Closed
clubby789 opened this issue Mar 18, 2025 · 0 comments · Fixed by #138692
Closed

Compiletest should reject true and false as revision names #138663

clubby789 opened this issue Mar 18, 2025 · 0 comments · Fixed by #138692
Assignees
@jieyouxu
Labels
A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@clubby789
Copy link
Contributor

clubby789 commented Mar 18, 2025 •
edited
Loading

Note: not a blocker for this stabilization, but we should reject revision names true and false in compiletest as well, because they will try to set --cfg=true and --cfg=false.

Originally posted by @jieyouxu in #138632 (comment)
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 18, 2025
@clubby789 clubby789 mentioned this issue Mar 18, 2025
Open
@clubby789 clubby789 added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-compiletest Area: The compiletest test runner and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Mar 18, 2025
@jieyouxu jieyouxu added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Mar 19, 2025
@jieyouxu jieyouxu mentioned this issue Mar 19, 2025
Merged
@jieyouxu jieyouxu self-assigned this Mar 19, 2025
jhpratt added a commit to jhpratt/rust that referenced this issue Mar 29, 2025
@jhpratt
Rollup merge of rust-lang#138692 - jieyouxu:reject-bool-lit-rev-names…
4dfcd70 
…, r=wesleywiser

Reject `{true,false}` as revision names

Because they would imply `--cfg={true,false}` otherwise, and the test writer has to use `cfg(r#true)` and `cfg(r#false)` in the test.

Closes rust-lang#138663.
jhpratt added a commit to jhpratt/rust that referenced this issue Mar 29, 2025
@jhpratt
Rollup merge of rust-lang#138692 - jieyouxu:reject-bool-lit-rev-names…
97b85d2 
…, r=wesleywiser

Reject `{true,false}` as revision names

Because they would imply `--cfg={true,false}` otherwise, and the test writer has to use `cfg(r#true)` and `cfg(r#false)` in the test.

Closes rust-lang#138663.
@bors bors closed this as completed in 240a4da Mar 29, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Mar 29, 2025
@rust-timer
Unrolled build for rust-lang#138692
af5422d 
Rollup merge of rust-lang#138692 - jieyouxu:reject-bool-lit-rev-names, r=wesleywiser

Reject `{true,false}` as revision names

Because they would imply `--cfg={true,false}` otherwise, and the test writer has to use `cfg(r#true)` and `cfg(r#false)` in the test.

Closes rust-lang#138663.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reject {true,false} as revision names jieyouxu/rust
3 participants
@clubby789 @jieyouxu @rustbot