Skip to content

Unbundle all 3rd party libraries. #13945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cicku opened this issue May 5, 2014 · 8 comments
Closed

Unbundle all 3rd party libraries. #13945

cicku opened this issue May 5, 2014 · 8 comments

Comments

@cicku
Copy link

cicku commented May 5, 2014

Hi,

I don't know if it's possible to unbundle all 3rd party libraries. I'm going to package it into Fedora, we disallow bundling in most cases. However before I try to unbundle them, I'd like to see if you are willing to see me doing this since using system libraries may cause problems and I'm not sure if you are willing to fix.

Thanks.

@alexcrichton
Copy link
Member

I'm curious, but what are the bundling requirements on fedora? None of the "bundled" packages are distributed as part of a rust installation, they're all statically linked into their respective rust artifacts. Other than that, this is the status of all our bundled repos:

  • LLVM - with ./configure --llvm-root=foo you can use a system LLVM
  • libuv - we're currently using an unreleased version of libuv I believe, but it's also a fairly small dependency
  • gyp - this is just a build dependency of libuv, we can probably get by with a system version
  • compiler-rt - this is required by LLVM, it's a pretty small project, but we have a good number of custom patches on top that we need.

@cicku
Copy link
Author

cicku commented May 6, 2014

  1. Static linking is not allowed in most cases in Fedora. If it can be linked shared, then do this.
  2. We have a clearly stated guideline:

https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

  1. Thanks for providing the significant info of the bundled libs list, LLVM is not a problem here, I'm concerned about the uv.
  2. compiler-rt, well I can request an exception(maybe) if you have patched it on top of the original code.

@alexcrichton
Copy link
Member

What's the version of libuv that fedora is distributing? It looks like we can maintain compatibility with the 0.11 series pretty easily, but there were some big changes from 0.10 to 0.11 that it'd take a much larger amount of support to work with 0.10.

@cicku
Copy link
Author

cicku commented May 6, 2014

Fedora ships(http://pkgs.org/search/?query=libuv):

  1. libuv-0.10.27 in rawhide(will be f21)
  2. libuv-0.10.25 in f20

So we are still on 0.10 series line.

@alexcrichton
Copy link
Member

Would it be possible to get an exception for libuv? It's a pretty small dependency (if that helps). Additionally, gyp is just a build dependency, we don't install it anywhere.

@cicku
Copy link
Author

cicku commented May 6, 2014

Maybe uh... Depends on the situation of rust, since I'm just a bystander, I'm not familiar with the compatibility that rust will carry in its series. I need a good explanation from upstream then I will send it to the packaging committee for final decision.

gyp is special, I need to rethink about it.

@thestinger
Copy link
Contributor

libuv / gyp are now removed as part of #17325

@alexcrichton
Copy link
Member

The two major native libraries we depend on are LLVM and jemalloc, both of which have options to specify an external build in the configure script, so I'm going to close this.

bors added a commit to rust-lang-ci/rust that referenced this issue Feb 13, 2023

Verified

This commit was signed with the committer’s verified signature.
fix: check orpat in missing match

fixed rust-lang#13942
flip1995 pushed a commit to flip1995/rust that referenced this issue Jan 9, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Close rust-lang#13938

changelog: [`missing_const_for_fn`]: do not trigger for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants