Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: consider running tests in a fresh temporary directory #13977

Closed
pnkfelix opened this issue May 6, 2014 · 2 comments
Closed

rustdoc: consider running tests in a fresh temporary directory #13977

pnkfelix opened this issue May 6, 2014 · 2 comments
Labels
T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@pnkfelix
Copy link
Member

pnkfelix commented May 6, 2014

Spawned off of Issue #13965. I had a couple nice illustrative bits of code that spewed output into some files. I didn't really think about the consequences of doing that with respect to the rustdoc workflow.

( What, doesn't everyone do their builds in an isolated build tree? No, not everyone? Wait, is it just me? :) ... )

Anyway, I guess this is a feature request that either rustdoc itself or our make infrastructure should ensure that the current working directory is set to a separate workspace when rustdoc runs, and the contents of that workspace should be deleted if rustdoc terminates without an error condition.

@steveklabnik steveklabnik added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 23, 2015
@steveklabnik
Copy link
Member

Triage: I am not aware of any change here.

@steveklabnik steveklabnik added T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. and removed T-tools labels May 18, 2017
@Mark-Simulacrum
Copy link
Member

I believe this is fixed today:

let outdir = Mutex::new(TempDir::new("rustdoctest").ok().expect("rustdoc needs a tempdir"));
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants