Skip to content

rustdoc has 4 different "open sidebar" buttons #139832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lolbinarycat opened this issue Apr 15, 2025 · 5 comments
Open

rustdoc has 4 different "open sidebar" buttons #139832

lolbinarycat opened this issue Apr 15, 2025 · 5 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Comments

@lolbinarycat
Copy link
Contributor

lolbinarycat commented Apr 15, 2025 •
edited by rustbot
Loading

desktop, after resizing the sidebar to nothing: Image

mobile: hamburger menu

file sidebar: folder icon

mobile, after resizing the sidebar to nothing in desktop mode then emulating a mobile layout with devtools (technically this one opens the topbar): Image

the open file sidebar at least i've heard some people not understanding what it does, thinking it would be some sort of "open sidebar" button or something.
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 15, 2025
@lolbinarycat lolbinarycat added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Apr 15, 2025
@SciMind2460
Copy link

@rustbot claim

@SciMind2460
Copy link

I personally think we should use the mobile versions. They seem to work coherently with the others.

@jieyouxu jieyouxu added C-bug Category: This is a bug. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Apr 15, 2025
@SciMind2460
Copy link

@rustbot label A-docs A-frontend

@rustbot rustbot added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-frontend Area: Compiler frontend (errors, parsing and HIR) labels Apr 15, 2025
@SciMind2460
Copy link

@rustbot release-assignment
I don't have the time right now.

@GuillaumeGomez GuillaumeGomez removed A-frontend Area: Compiler frontend (errors, parsing and HIR) A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Apr 21, 2025
@GuillaumeGomez
Copy link
Member

For the file sidebar and the mobile sidebar to share the same icon, I agree, their purpose it the same.

However for the two other images, I don't think it's a good idea as their purpose isn't the same.

@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 21, 2025
Open
@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed C-bug Category: This is a bug. labels Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@GuillaumeGomez @lolbinarycat @jieyouxu @rustbot @SciMind2460