run-make test failures when building rust-with rpath disabled
#140738
Labels
A-run-make
Area: port run-make Makefiles to rmake.rs
A-test-infra
Area: test infrastructure (may span bootstrap/compiletest/more)
C-bug
Category: This is a bug.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Comments
rustbot
added
the
needs-triage
jchecahi
pushed a commit
to jchecahi/rust
that referenced
this issue
May 7, 2025
Some run-make tests invoke Cargo via run_make_support::cargo(), but fail to execute correctly when rustc is built without rpath. In these setups, runtime loading of rustc’s shared libraries fails unless the appropriate dynamic library path is set manually. This commit updates the cargo() wrapper to call set_host_compiler_dylib_path(), aligning its behavior with the existing rustc() wrapper: https://github.com/rust-lang/rust/blob/f76c7367c6363d33ddb5a93b5de0d158b2d827f6/src/tools/run-make-support/src/external_deps/rustc.rs#L39 This ensures that Cargo invocations during tests inherit the necessary dylib paths, avoiding errors related to missing shared libraries in rpath-less builds. Fixes part of rust-lang#140738
jieyouxu
added
T-compiler
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this issue
May 7, 2025
…stc-dylib, r=jieyouxu run-make-support: set rustc dylib path for cargo wrapper Some run-make tests invoke Cargo via run_make_support::cargo(), but fail to execute correctly when rustc is built without rpath. In these setups, runtime loading of rustc’s shared libraries fails unless the appropriate dynamic library path is set manually. This commit updates the cargo() wrapper to call set_host_compiler_dylib_path(), aligning its behavior with the existing rustc() wrapper: https://github.com/rust-lang/rust/blob/f76c7367c6363d33ddb5a93b5de0d158b2d827f6/src/tools/run-make-support/src/external_deps/rustc.rs#L39-L43 This ensures that Cargo invocations during tests inherit the necessary dylib paths, avoiding errors related to missing shared libraries in rpath-less builds. Fixes part of rust-lang#140738
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this issue
May 8, 2025
Rollup merge of rust-lang#140745 - jchecahi:run-make-support-cargo-rustc-dylib, r=jieyouxu run-make-support: set rustc dylib path for cargo wrapper Some run-make tests invoke Cargo via run_make_support::cargo(), but fail to execute correctly when rustc is built without rpath. In these setups, runtime loading of rustc’s shared libraries fails unless the appropriate dynamic library path is set manually. This commit updates the cargo() wrapper to call set_host_compiler_dylib_path(), aligning its behavior with the existing rustc() wrapper: https://github.com/rust-lang/rust/blob/f76c7367c6363d33ddb5a93b5de0d158b2d827f6/src/tools/run-make-support/src/external_deps/rustc.rs#L39-L43 This ensures that Cargo invocations during tests inherit the necessary dylib paths, avoiding errors related to missing shared libraries in rpath-less builds. Fixes part of rust-lang#140738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Similar to #140299, we're seeing some
run-maketests failing to run due to missinglibrustc_driverwhen building withrpathdisabled:Tests that fail:
The root cause is that these tests either:
Command::new(env_var("RUSTC"))instead using therustc()wrapper provided by run-make-support, orcargo()wrapper fromrun-make-support, which doesn't set the runtime library path (e.g. LD_LIBRARY_PATH) likerustc()does.To reproduce in a clean tree:
./config --disable-rpath python x.py test --force-rerun tests/run-make/{broken-pipe-no-ice,compiler-builtins,rustc-crates-on-stable}Originally reproduced on beta (973ec11), still happens on latest master (71b68da).
The text was updated successfully, but these errors were encountered: