-
Notifications
You must be signed in to change notification settings - Fork 13.3k
poor diagnostic for unsupported -fuse-ld=lld flag #140964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Since we do support a range of Linux distributions, based on the minimal supported glibc version, I agree that LLD should work out of the box (without any weird warnings) on all of these distribution. And since some of these indeed seem to use too old GCC, we should IMO get rid of the error, at least in the case where we do use the default option. CC @lqd (happy to work on implementing this) |
I don't know why these are We can remove the warning from the |
I can't tell from #97402 whether we didn't explore the |
On older platforms (e.g., Amazon Linux 2 is where I encountered this), the current implementation of LLD-by-default in rustc leads to a tracing::warn! log line: https://github.com/rust-lang/rust/blob/dcecb99176edf2eec51613730937d21cdd5c8f6e/compiler/rustc_codegen_ssa/src/back/link.rs#L771C24-L771C54
This is at minimum a diagnostics bug, but I'm not sure the warning makes sense -- if we're not able to use LLD and have a well-supported fallback path, as long as the user isn't explicitly requesting LLD it seems plausible that a silent fallback is better than complaining noisily (and still falling back)?
The text was updated successfully, but these errors were encountered: