Skip to content

Conversation

lqd
Copy link
Member

@lqd lqd commented May 15, 2025

As discussed in #140964 and IRL, this PR switches the spammy warning shown unconditionally when an old gcc doesn't support -fuse-ld=lld and we retry linking without it, to an info debug log so we don't lose it.

r? @Mark-Simulacrum

Fixes #140964

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 15, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 17, 2025

📌 Commit 55ad9cd has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2025
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#135808 (Implement Display for ``rustc_target::callconv::Conv``)
 - rust-lang#137432 (Add as_ascii_unchecked() methods to char, u8, and str)
 - rust-lang#139103 (deduplicate abort implementations)
 - rust-lang#140917 (checktools.sh: fix bashism)
 - rust-lang#141035 (turn lld warning on old gccs into info log)
 - rust-lang#141118 (Enable rust-analyzer to go from query definition to the corresponding provider field)
 - rust-lang#141121 (Only select true errors in `impossible_predicates`)
 - rust-lang#141125 (check coroutines with `TypingMode::Borrowck` to avoid cyclic reasoning)
 - rust-lang#141131 (Make some `match`es slightly more ergonomic in `librustdoc`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 73ea8d7 into rust-lang:master May 17, 2025
6 checks passed
@rustbot rustbot added this to the 1.89.0 milestone May 17, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 17, 2025
Rollup merge of rust-lang#141035 - lqd:lld-warn, r=Mark-Simulacrum

turn lld warning on old gccs into info log

As discussed in rust-lang#140964 and IRL, this PR switches the spammy warning shown unconditionally when an old gcc doesn't support `-fuse-ld=lld` and we retry linking without it, to an info debug log so we don't lose it.

r? `@Mark-Simulacrum`

Fixes rust-lang#140964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

poor diagnostic for unsupported -fuse-ld=lld flag
4 participants