Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementations of cross-crate traits missing in rustdoc #14125

Closed
sfackler opened this issue May 12, 2014 · 0 comments
Closed

Implementations of cross-crate traits missing in rustdoc #14125

sfackler opened this issue May 12, 2014 · 0 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@sfackler
Copy link
Member

For example, PostgresRows implements Iterator, but that fact has stopped showing up in its documentation: http://sfackler.github.io/rust-postgres/doc/postgres/struct.PostgresRows.html
alexcrichton added a commit to alexcrichton/rust that referenced this issue May 12, 2014
@alexcrichton
rustdoc: Fix hiding implementations of traits
50ec2cb 
This bug was introduced when rustdoc gained the ability to hyperlink across
crates in pub use statements.

Closes rust-lang#14125
@alexcrichton alexcrichton mentioned this issue May 12, 2014
Closed
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 13, 2023
@bors
Auto merge of rust-lang#14125 - Veykril:inlay-fix, r=Veykril
d78a0be 
fix: Fix bind pat inlay hints rendering for constant patterns

Fixes rust-lang/rust-analyzer#14124
flip1995 pushed a commit to flip1995/rust that referenced this issue Feb 20, 2025
@blyxyas
declare_interior_mutable_const, borrow_interior_mutable_const: re…
c40898e 
…solve `<T as Trait>::AssocT` projections (rust-lang#14125)

changelog: [`declare_interior_mutable_const`,
`borrow_interior_mutable_const`]: resolve `<T as Trait>::AssocT`
projections

---

This came up during rust-lang#130543 where
we have `<T as AtomicPrimitive>::Assoc = AtomicT` instead of just
`AtomicT` and clippy failed to resolve that properly.

This really needs a review, because

- I don't know if `try_normalize_erasing_regions` is the right thing to
call here.
- I'm not sure if I peel off the correct amount of `ValTree::Branch`
layers (I think I do).

Also, shouldn't this lint's infrastructure rely on `Freeze` trait
(rust-lang#121675) instead of hardcoding
a list of known-to-be-interior-mutable types?

---

Previously filed this in the main rust repo
(rust-lang#136369), was asked to do it here
instead
(rust-lang#136369 (comment)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustdoc: Fix hiding implementations of traits alexcrichton/rust
1 participant
@sfackler