Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename StrBuf to String #14312

Closed
alexcrichton opened this issue May 21, 2014 · 2 comments · Fixed by #14323
Closed

Rename StrBuf to String #14312

alexcrichton opened this issue May 21, 2014 · 2 comments · Fixed by #14323
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Milestone
1.0

Comments

@alexcrichton
Copy link
Member

Tracking issue for rust-lang/rfcs#60

Nominating.
@richo
Copy link
Contributor

richo commented May 21, 2014

I tried asking on IRC, hoping to get this out tonight because it looked achievable.

What's the plan for the String trait as well as the existing String type. I feel like limiting the visibility of the string type is probably fine, but the String trait is necessary for formatters.

@richo richo mentioned this issue May 21, 2014
Merged
@pnkfelix
Copy link
Member

P-backcompat-libs, 1.0.

@pnkfelix pnkfelix added this to the 1.0 milestone May 22, 2014
bors added a commit that referenced this issue May 25, 2014
@bors
auto merge of #14323 : richo/rust/features/strbuf_to_string, r=huonw
7d76d0a 
Converts `StrBuf` to `String` throughout rustc and the standard library.

Tests all pass locally, but usual caveats about platforms that aren't OSX apply since I don't have a test environment handy.

@alexcritchon mentioned that @pcwalton may have a patch incoming that should block this?

closes #14312
lnicola pushed a commit to lnicola/rust that referenced this issue Mar 13, 2023
@bors
Auto merge of rust-lang#14312 - HKalbasi:master, r=lnicola
1b5bba4 
Revert rust-lang#14285

fix rust-lang#14305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented.
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Features/strbuf to string richo/rust
3 participants
@alexcrichton @pnkfelix @richo