Skip to content

find_linkage_metas is unused #14329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jdm opened this issue May 21, 2014 · 3 comments · Fixed by #14956
Closed

find_linkage_metas is unused #14329

jdm opened this issue May 21, 2014 · 3 comments · Fixed by #14956
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@jdm
Copy link
Contributor

jdm commented May 21, 2014

From attr.rs in libsyntax, find_linkage_metas does not appear to have any callers in rustc. Seems like a good candidate for removal.
@jdm jdm added the E-easy label May 21, 2014
@kaseyc
Copy link
Contributor

kaseyc commented May 30, 2014

Should this be removed? Or it is still under discussion?

@nathantypanski
Copy link
Contributor

AFAICT this code is dead. Sending a PR, maybe someone will tell me why it needs to stay.

nathantypanski added a commit to nathantypanski/rust that referenced this issue Jun 17, 2014
@nathantypanski
libsyntax: remove dead code find_linkage_metas
b68fa1a 
Closes rust-lang#14329
@nathantypanski nathantypanski mentioned this issue Jun 17, 2014
Merged
@nathantypanski
Copy link
Contributor

Blergh. Sorry for dirtying this bug report. It took me a while to go through the grep output, and after a couple of tries I just gave up.

bors added a commit that referenced this issue Jun 17, 2014
@bors
auto merge of #14956 : nathantypanski/rust/master, r=alexcrichton
1bb42e5 
Closes #14329

Recent-ish uses of `find_linkage_metas` from my `git grep` output are [here](https://gist.github.com/nathantypanski/b9d2d453718a22765f5c), for those interested who wish to tread through the history.
flip1995 pushed a commit to flip1995/rust that referenced this issue Mar 20, 2025
@dswij
rename the MSRV alias MANUAL_DIV_CEIL to DIV_CEIL (rust-lang#14329)
19930f9 
I renamed the MSRV alias `MANUAL_DIV_CEIL` to `DIV_CEIL` in rust-lang#14263, as
MSRV aliases should represent their capability rather than the lint
name. However, it seems this change was mistakenly overwritten in
rust-lang#14022.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libsyntax: remove dead code find_linkage_metas nathantypanski/rust
3 participants
@jdm @nathantypanski @kaseyc