Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or replace core::finally #14332

Closed
brson opened this issue May 21, 2014 · 0 comments · Fixed by #21082
Closed

Remove or replace core::finally #14332

brson opened this issue May 21, 2014 · 0 comments · Fixed by #21082

Comments

@brson
Copy link
Contributor

brson commented May 21, 2014

There is clearly a use case for running a deterred computation, but finally's API is quite unwieldy now.
@brson brson added the A-libs label May 21, 2014
brson added a commit to brson/rust that referenced this issue Jan 13, 2015
@brson
std: Deprecate finally module
e46620a 
No in-tree users. Ugly interface. Closes rust-lang#14332.
@brson brson mentioned this issue Jan 13, 2015
Merged
bors added a commit that referenced this issue Jan 14, 2015
@bors
auto merge of #21082 : brson/rust/finally, r=alexcrichton
896cb36 
No in-tree users. Ugly interface. Closes #14332.

I just happened to notice that this module still lives and has no users. Assuming we don't want it.

r? @aturon cc @alexcrichton
flip1995 pushed a commit to flip1995/rust that referenced this issue Apr 3, 2025
@Manishearth
Unify manual_unwrap_or and manual_unwrap_or_default code (rust-la…
1893e1e 
…ng#14332)

Both lints share a lot of characteristics but were implemented in
unrelated ways. This unifies them, saving around 100 SLOC in the
process, and making one more test trigger the lint. Also, this removes
useless blocks in suggestions.

Close rust-lang#12956

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

std: Deprecate finally module brson/rust
1 participant
@brson