Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linking an rlib with a dylib may not actually link the rlib #14344

Closed
alexcrichton opened this issue May 21, 2014 · 2 comments
Closed

Linking an rlib with a dylib may not actually link the rlib #14344

alexcrichton opened this issue May 21, 2014 · 2 comments
Labels
A-linkage Area: linking into static, shared libraries and binaries

Comments

@alexcrichton
Copy link
Member

When linking an rlib to a dylib, it must be required that the object file for the rlib is included in the dylib. Linkers will optimize away the object file if the dylib doesn't actually use any symbols from the rlib.

Downstream consumers of the rlib (using the rlib through the dylib) may want the symbols, ending up with linker errors.

Basically, we need to tell linkers to force inclusion of all objects from an rlib into a dylib. I think this also applies to native objects inside of an rlib.
@alexcrichton
Copy link
Member Author

Updated with a real description.

@alexcrichton alexcrichton mentioned this issue May 22, 2014
Closed
@alexcrichton alexcrichton mentioned this issue Jun 4, 2014
Merged
@alexcrichton alexcrichton mentioned this issue Sep 18, 2014
Closed
@alexcrichton
Copy link
Member Author

test case: https://gist.github.com/UberLambda/5fe6479eb9afd1737cec

@Mutisk-zz Mutisk-zz mentioned this issue Sep 29, 2014
Closed
@mbrubeck mbrubeck mentioned this issue Oct 2, 2014
Merged
@alexcrichton alexcrichton mentioned this issue Oct 4, 2014
Closed
@larsbergstrom larsbergstrom mentioned this issue Oct 7, 2014
Closed
1 task
bors-servo pushed a commit to servo/servo that referenced this issue Oct 9, 2014
auto merge of #3563 : mbrubeck/servo/app2, r=larsbergstrom
74fc874 
This includes the previously-reviewed commits from #3533, plus additional fixes for test failures, and a workaround for CEF link errors on Mac (related to rust-lang/rust#14344).  Opening a new PR because this required a fairly invasive rebase, and the original was polluted by a bunch of test commits. r? @larsbergstrom
bors-servo pushed a commit to servo/servo that referenced this issue Oct 10, 2014
auto merge of #3563 : mbrubeck/servo/app2, r=larsbergstrom
528ad45 
This includes the previously-reviewed commits from #3533, plus additional fixes for test failures, and a workaround for CEF link errors on Mac (related to rust-lang/rust#14344).  Opening a new PR because this required a fairly invasive rebase, and the original was polluted by a bunch of test commits. r? @larsbergstrom
@alexchandel alexchandel mentioned this issue Nov 3, 2014
Closed
alexcrichton added a commit to rust-lang/git2-rs that referenced this issue Nov 7, 2014
@alexcrichton
Work around rust-lang/rust#14344
945388a
alexcrichton added a commit to alexcrichton/ssh2-rs that referenced this issue Nov 7, 2014
@alexcrichton
Work around rust-lang/rust#14344
0af4463
klutzy added a commit to klutzy/rust that referenced this issue Nov 21, 2014
@klutzy
rustc_trans: Link archives with --whole-archive
04ea114 
If archives are passed to linker, linker does not add all object files
but instead scans each object in archive then adds it only if it
defines some symbols which has been undefined.
It is problematic when rlib needs to be contained in dylib, since
some portion of rlib is stripped out if unused by dylib itself.

This patch uses `--whole-archive` flag which changes linker behavior
that the linker just adds all objects in archive.
Unfortunately, ld does not accept rlib as-is because it contains
non-object files, so they are manually removed before passed to ld.

Also, this change can be problematic if several archives actually
contain same symbol. For example, this patch breaks code like:

```Rust
    #![crate_type = "rlib"]

    // `libcfoo.a` contains `foo`.
    #![link(name = "cfoo", kind = "static")]
    extern {}

    // `foo` is also defined here!
    #[no_mangle]
    pub fn foo() {}

    // so this rlib archive has two `foo` symbols.
```

Previously it worked because linker stripped out `cfoo`.

Fixes rust-lang#14344
@klutzy klutzy mentioned this issue Nov 21, 2014
Closed
@elinorbgr elinorbgr mentioned this issue May 22, 2015
Closed
@alexcrichton alexcrichton mentioned this issue Jun 6, 2015
Closed
@goertzenator goertzenator mentioned this issue Jun 19, 2015
Closed
This was referenced Jul 2, 2015
Closed
Closed
@alexcrichton alexcrichton mentioned this issue Jul 8, 2015
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 20, 2023
@bors
Auto merge of rust-lang#14347 - HKalbasi:dev, r=lnicola
5780375 
Add storage dead for let bindings without initializer

fix rust-lang#14344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-linkage Area: linking into static, shared libraries and binaries
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rustc_trans: Link archives with --whole-archive klutzy/rust
1 participant
@alexcrichton